Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Bug] ReorderOperation with more than 200 records

See original GitHub issue

Bug report

What I did

I set up a model that uses ReorderOperation.

What I expected to happen

Reordering and saving stores the information in the database and after refresh of the view, the data is still shown with the new order.

What happened

Order was not persisted into the database. After a refresh, the old order was shown.

What is the cause of the issue

When there are more than 200 records to reorder (not an edge case with a bigger shop with multiple subcategories), the $.ajax request data gets cut inside PHP and PHP receives only the first 200 records. The reason is that data is sent as an array from JS and PHP has a max_input_vars which is by default 1000. Every record in the array (every model item) contains multiple properties ({item_id: "1", parent_id: 5, depth: 0, left: 11 right: 21}), so 200 multiplied by 5.

What I’ve already tried to fix it

There are two possible solutions:

Increase the max_input_vars value. I do not like this because of the possible denial of service concerns and changing the PHP ini is not always easy for all hostings.

Instead of sending an array, send the data as json string and decode it back when received in PHP. This requires two changes in the code:

In vendor/backpack/crud/src/resources/views/crud/reorder.blade.php replace

$.ajax({
    url: '{{ url(Request::path()) }}',
    type: 'POST',
    data: { tree: arraied },
})

with

$.ajax({
    url: '{{ url(Request::path()) }}',
    type: 'POST',
    data: { tree: JSON.stringify(arraied) },
})

In vendor/backpack/crud/src/app/Http/Controllers/Operations/ReorderOperation.php replace

public function saveReorder()
{
    $this->crud->hasAccessOrFail('reorder');

    $all_entries =\Request::input('tree');

    if (count($all_entries)) {
        $count = $this->crud->updateTreeOrder($all_entries);
    } else {
        return false;
    }

    return 'success for '.$count.' items';
}

with

public function saveReorder()
{
    $this->crud->hasAccessOrFail('reorder');

    $all_entries = json_decode(\Request::input('tree'), true);

    if (count($all_entries)) {
        $count = $this->crud->updateTreeOrder($all_entries);
    } else {
        return false;
    }

    return 'success for '.$count.' items';
}