Custom order logic produces error with search

Bug report

What I did

I created a custom order logic to order by a relationship field like the following:

return $query->leftJoin('users', 'users.id', '=', 'rooms.user_id')
                        ->orderBy('users.email', $columnDirection)->select('rooms.*');

What I expected to happen

I expect that it doesn’t affect any other functionality in the CRUD.

What happened

Whenever I do a search query in the CRUD while the sorting of that relationship field is triggered … I get the following error in the Ajax.

"SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'id' in where clause is ambiguous (SQL: select `rooms`.* from `rooms` left join `users` on `users`.`id` = `rooms`.`user_id` where (`id` like %a% or exists (select * from `users` where `rooms`.`user_id` = `users`.`id` and `email` LIKE %a%) or `bedrooms` like %a% or `bathrooms` like %a% or `roommates` like %a% or `gender` like %a% or `rent` like %a% or `plan` like %a% or `status` like %a%) and `rooms`.`deleted_at` is null order by `users`.`email` asc, `id` desc limit 10)"

If I remove the search query from the search field and try to order by the relationship column it works well.

What I’ve already tried to fix it

Tried to debug the issue and follow the documentation but no luck.

Backpack, Laravel, PHP, DB version

When I run php artisan backpack:version the output is:

### PHP VERSION:
PHP 7.3.17 (cli) (built: Apr 16 2020 13:00:36) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.17, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.17, Copyright (c) 1999-2018, by Zend Technologies

### LARAVEL VERSION:
v5.8.38@78eb4dabcc03e189620c16f436358d41d31ae11f

### BACKPACK VERSION:
4.0.61@1977e0cc52fa7cf9547eaeadf03f5cd88402b574

[tabacitu]

I agree @lilessam - if the package can handle that automatically, it should. So I’m going to put this on the list of things to do, thanks!

[tabacitu]

I see @pxpm just submitted #3015 which fixes this, so let’s move the conversation there please! Thanks for raising the issue @lilessam !