Delete and Observables

Delete has the following trait (https://github.com/Laravel-Backpack/CRUD/blob/master/src/PanelTraits/Delete.php):

    /**
     * Delete a row from the database.
     *
     * @param  [int] The id of the item to be deleted.
     * @param int $id
     *
     * @return [bool] Deletion confirmation.
     *
     * TODO: should this delete items with relations to it too?
     */
    public function delete($id)
    {
        return (string) $this->model->find($id)->delete();
    }

If one forces that (string) cast out to make this an actual PHP bool (i.e. true && false) then the AJAX table always figures there is an issue.

I would note that Laravel’s Eloquent returns false if an observable returns false, e.g:

(Illuminate\Database\Eloquent\Model - Laravel:~5.4)

 616     /**
 617      * Perform a model insert operation.
 618      *
 619      * @param  \Illuminate\Database\Eloquent\Builder  $query
 620      * @return bool
 621      */
 622     protected function performInsert(Builder $query)
 623     {
 624         if ($this->fireModelEvent('creating') === false) {
 625             return false;
 626         }

Might it be better to return whatever the underlying create operation returned rather than cast it to a string?

[lloy0076]

@tumf87 - I’m not sure we disagree with each other (and in fact, one just substitutes whatever in the various return response(...) to boot).

I should turn it into a PR I suppose.

[lloy0076]

Ok, this just got noticed again - reopening.