`pivotFields` functionality broken

So I saw that there is an undocumented feature for adding additional data to pivot columns here:

https://github.com/Laravel-Backpack/CRUD/blob/57666443a1c4db57a76470d0876dac9cbab6ced9/src/PanelTraits/Create.php#L86-L92

if (isset($field['pivotFields'])) {
    foreach ($field['pivotFields'] as $pivotField) {
        foreach ($data[$pivotField] as $pivot_id =>  $field) {
            $model->{$field['name']}()->updateExistingPivot($pivot_id, [$pivotField => $field]);
        }
    }
}

Looks like the reason for this is that you’re referencing $field['name'] on line 89, even though the $field variable has been overwritten inside of the current (nested) foreach.

[tabacitu]

Fixed on dev. Thank you @hewok for the PR! Cheers!

[hewok]

Hi @lloy0076 , no, there is not PR for the bug. [EDIT]: @lloy0076 I’ve created PR.

Hi @tabacitu , I’ve changed the $value of the for loop, exactly the “$pivot_field”. The problem is the variable $field (now, on master branch) on line 99 will be overwritten by for loop on line 106

https://github.com/Laravel-Backpack/CRUD/blob/6e31f985e902bd8d0b5891db143cad8d79427e6e/src/PanelTraits/Create.php#L99-L111

When try to save the page, where I’ve used the addField functionally, I received the error:

Illegal string offset ‘name’

because $field[‘name’] (on line 107) is not the correct field name.

If anyone want to try (you need to update some info 😉 ):

$this->crud->addField([
      'label' => "Element list",
      'type' => 'block_weight',
      'name' => 'blocks', // the method that defines the relationship in your Model
      'entity' => 'block', // the method that defines the relationship in your Model
      'attribute' => 'title', // foreign key attribute that is shown to user
      'model' => "App\Models\Block", // foreign key model
      'pivot' => true, // on create&update, do you need to add/delete pivot table entries?
      'pivotFieldsLabel' => ['Weight'],
      'pivotFields' => [
            'weight'
      ],
]);

I hope I’m making myself clear.