Remove underscores from column names in setFromDb()

I find myself having to re-write the fields and columns for very basic crud models, just because the titles of the columns have underscores in them. For instance, this is a model that simply has text fields, so the setFromDb() function would be entirely sufficient, but I will need to write all the addColumns() and addFields() functions in order to remove the underscores:

Would there be any issues caused by labeling these columns and fields with removed underscores?

[jsiebach]

@tabacitu I think that would be non breaking and be a good change. I do however like @lloy0076 solution better - a callable function would let me customize the names of all of my columns, without having to re-write all of the fields and columns. There are probably people out there who use snake case for their column names (no friends of mine, to be sure!) who may have different logic for their app. With a callable we could do something like:

$this->crud->setFromDb(function($column){
	$fieldmap = [
		'id' => 'ID',
		'phone_number' => 'Phone Number',
		'email' => 'Email Address'
	];

	return $fieldmap[$column];
});

This avoids all of the fields and columns being manually added, and adds a ton of flexibility. You could even set column titles using application logic if you wanted, ie. using the Crud/Settings package.

[tabacitu]

Yup, I think #688 is a good fix for this.