Transformer interface and behavior change in 0.6.0

Hi !

I was wondering: why did the interface for Transformer methods change ?

I used to have:

class MyTransformer(Transformer_NoRecuse):
    def some_rule(self, tree: Tree):
        tree.children = [...]    # Some changes on children + access to tree class
        return tree

Now, when converting to Transformer_InPlace), I’m bothered by the fact that a function rule will delete the tree. e.g.

class MyTransformer(Transformer_InPlace):
    def some_rule(self, values: List):
        values = [...]    # Some changes on values + no access to tree class :(
        return values   # <- In the final tree, the `some_rule` node has disappeared !

I can update my code to the new Transformer_InPlace with many changes but having access to the tree and a way to rewrite portions and/or delete the tree element gave more flexibility in the usage. What is the rationale behind removing trees in arguments to transformer functions ? Is there a way to have access to the tree in each transformer functions ?

Thanks for the wonderful work you’re doing on lark 😃

[erezsh]

Actually, having looked at both, I think MkDocs is probably better for Lark, because

1. It uses Markdown, which is simpler, and it’s what the existing documentation uses

2. It has nicer default themes

[achedeuzot]

I’ve used Sphinx in the past and it was straightforward to set up and use.

There’s good documentation here: http://dont-be-afraid-to-commit.readthedocs.io/en/latest/documentation.html

Would you want me to suggest a pull-request for this ?