Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[iOS] On closing modal by pressing outside - triggered onDonePress function

See original GitHub issue

Describe the bug
The onDonePress function should not be triggered on closing picker modal on iOS

To Reproduce

Open Picker modal on iOS device
Change selected value
Press outside the modal area to close/dismiss changes
onDonePress function was triggered

Expected behavior
onDonePress function should not be called onCancel function triggered (optional)

Suggested solution
Please, remove onDismiss prop here - https://github.com/lawnstarter/react-native-picker-select/blob/master/src/index.js#L425 And add calling of onDonePress function here - https://github.com/lawnstarter/react-native-picker-select/blob/master/src/index.js#L345

Additional details

Device: any iPhone
OS: iOS12+
react-native-picker-select version: 6.3.3
react-native version: 0.61.1
react version: 16.9.0

Reproduction and/or code sample

<PickerSelect
        value={this.state.selected}
        onValueChange={(selected) => {
          this.setState({ selected });
        }}
        items={items}
        onDonePress={() => {
          console.log('done pressed') // message will be shown even on modal cancel request
          onValueChange(this.state.selected);
        }}
      >
        // some label
      </PickerSelect>