Can't claim Channel Surfing reward

I’ve been able to claim all rewards, except the “Channel Surfing” reward. I created an identity yesterday and published a video under it: lbry://@CboyardeeArchive/aphidamp When I try to claim the reward, it says “Please create a channel identity first.” Using the network view I can see it makes two requests. “unused_wallet_address”, and “claim_list_mine”.

{"jsonrpc":"2.0","method":"wallet_unused_address","params":{},"id":1294}
{"jsonrpc":"2.0","method":"claim_list_mine","params":{},"id":1295}

The response for the first request is just a wallet address, and the second is this.

daemon (lbrynet)	0.13.1-14-gebec2fe
wallet (lbryum)	2.8.4
interface	0.12.2rc2
Platform	Linux (Linux-4.9.30-rt20-1-rt-x86_64-with-glibc2.2.5)

[lyoshenka]

@tzarebczan and I have figured it out. The issues is that the following function in reward.js is wrong:

function isInitialClaim(claim) {
  const reversed = reverseString(fromHex(claim.txid));
  const concat = reversed.concat(pack(claim.nout));
  const sha256 = new hashes.SHA256({ utf8: false }).raw(concat);
  const ripemd160 = new hashes.RMD160({ utf8: false }).raw(sha256);
  const hash = toHex(reverseString(ripemd160));
  return hash == claim.claim_id;
}

The solution is to either fix it, or use another method of determining whether a claim is an update, or to just drop this check.

The function is called on reward.js line 152, and was put there for a reason (d77fc883d1272b3f0cf8f0578c74e6fc752f9535), but it may no longer be necessary.

Here’s a sample claim, for testing. isInitialClaim() should return true for this, but it returns false.

{
  "address": "bTe9jQQnmFEqmPKZnoMgmUqU3JxWDEeCTG",
  "amount": 1.0,
  "category": "claim",
  "claim_id": "3c0c4987f349b882f49eeddbe3ed4f6630abb244",
  "name": "@kcseb",
  "nout": 1,
  "txid": "d54908242fd50627cd8a39b1a6858f7295d5c9e0771d185437ed2d254738fa58",
}

[tzarebczan]

Verified fix on a user’s PC