Feature Request: Enable ability for downstreams to disable upgrade checking.
See original GitHub issueThe Issue
As a package maintainer for a downstream Linux operating system (Solus), I’d prefer to directly provide users with an upgraded package which respects our routine syncs to our stable repo, ensures that such app upgrades won’t negatively impact users, and alleviates any concerns on my part about unexpected behavior being reported to us for changes that may occur (such as a gained dependency that isn’t installed on the user’s system).
Currently, the LBRY app runs a check in src/renderer/redux/actions/app.js
to see if an upgrade is available and subscribes to checks, however this is limited to a user-set disabling to skip an upgrade.
Ideally, I’d like an option as a downstream to disable upgrade checking entirely, even if it’s via an option with yarn
. Currently I’ve opted to just patch out (with some overkill) update checking but would obviously like a more official solution.
Acceptance Criteria
Definition of Done
- Tested against acceptance criteria
- Tested against the assumptions of the user story
- The project builds without errors
- Unit tests are written and passing
- Tests on devices/browsers listed in the issue have passed
- QA performed & issues resolved
- Refactoring completed
- Any configuration or build changes documented
- Documentation updated
- Peer Code Review performed
Issue Analytics
- State:
- Created 6 years ago
- Comments:11 (10 by maintainers)
Thanks @JoshStrobl! I strongly suspect we can accommodate this. Maybe one for @IGassmann?
@JoshStrobl hard-checking for a file on disk is a viable solution with a low time cost. I don’t see why we couldn’t do that. We’ve got to get through this upcoming release + lbry.tv release (which are basically the same release), but I’ll see if we can get this in in the release behind that one.