Styling Fixes - buttons / whitespace
See original GitHub issueOpen File button is not inline
with the other buttons creating unnecessary whitespace and looks broken.
Result
A few minor changes, including fixing the auto-play tick-box and subscribe button and you end up with:
Issue Analytics
- State:
- Created 5 years ago
- Comments:9 (4 by maintainers)
Top Results From Across the Web
white-space - CSS: Cascading Style Sheets - MDN Web Docs
The white-space CSS property sets how white space inside an element is handled.
Read more >Adding a button creates white space between div's - CSS-Tricks
So I added a button inside a div and it created white space between its container div and the div above. There are...
Read more >css - How to remove white spaces around the button in HTML?
First of all, <a> should not contain any other Action Elements (like <button> ). Secondly, stop using inline style attributes. · Start by...
Read more >Button: `white-space` set to `nowrap` · Issue #281 - GitHub
Just curious, what's the purpose of white-space no wrap for button elements. Is there a specific problem it's solving?
Read more >Fixing a blank white space at the bottom of your website
Fixing a blank white space at the bottom of your website · Reset CSS. Use a CSS reset like the one attached here,...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Made some improvements but I’ll keep this open if there is more discussion
Q) We should keep the border-radius so we have a consistent button style.
A) Yes, consistency paramount. I was playing around with theme ideas. The app could do with some more. I’ve got some great ideas in this department, which I am working on in my secret basement at groom lake, hehe!
Q) I think the subscription button should still stay on the right side, it is related to the channel, not the file, so I don’t think it should be grouped with the file actions
A) Yes. However, it currently looks like it’s there because the code is broken. It needs some love so that it looks like it’s meant to be there.
Q) You can hold off the autoplay styling. It will be improved here #1599
A) Sure. IMO, a nice toggle button would work well.