Calling `settings_set` writes invalid config in the daemon_settings.yml

daemon_settings.yml before and after passing a valid setting(happens for any setting, either valid or invalid) Specifically lbryum_servers field is overwritten in the python’s list format instead of colon separated

$ cat ~/.lbrynet/daemon_settings.yml
 blockchain_name: lbrycrd_regtest
 download_directory: /home/hackrush/Downloads
 lbryum_servers:
 - localhost:50001
 reflect_uploads: false
 share_usage_data: false
 use_upnp: false

$ lbrynet-cli settings_set --download_directory="/home/hackrush/Downloads" > /dev/null

$ cat ~/.lbrynet/daemon_settings.yml
 blockchain_name: lbrycrd_regtest
 download_directory: /home/hackrush/Downloads
 lbryum_servers:
 - [localhost, 50001]
 reflect_uploads: false
 share_usage_data: false
 use_upnp: false

[tzarebczan]

@KamilPiekutowski can you see if this still happens on 0.19 RC37 using his example. You should be able to create that file from scratch with his settings and see if it still messes up the sever list.

[tzarebczan]

Ran into the same on Windows: If you have a custom lbryum_servers: config in your daemon_settings.yml such as:

{disable_max_key_fee: false, download_directory: 'C:\Users\testaccountclean\Desktop',
 share_usage_data: true,
 lbryum_servers: ["victor.lbry.tech:50001"]}

And then go into app settings to change any persistent settings, i.e. max key fee, the file is then saved as (notice missing curley braces and syntax):

disable_max_key_fee: false
download_directory: C:\Users\testaccountclean\Desktop
lbryum_servers:
- [victor.lbry.tech, 50001]
share_usage_data: true

When restarting the daemon, you get:

Traceback (most recent call last):
  File "lbrynet-daemon-script.py", line 2, in <module>
  File "site-packages\lbrynet\daemon\DaemonControl.py", line 61, in start
  File "site-packages\lbrynet\conf.py", line 532, in load_conf_file_settings
  File "site-packages\lbrynet\conf.py", line 508, in _convert_conf_file_lists
  File "site-packages\lbrynet\conf.py", line 167, in server_list
  File "site-packages\lbrynet\conf.py", line 162, in server_port
AttributeError: 'list' object has no attribute 'split'
Failed to execute script lbrynet-daemon-script

The correct syntax would be:

lbryum_servers:
- "victor.lbry.tech:50001"

or lbryum_servers: ["victor.lbry.tech:50001"]