Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Namespace all selectors and styles using BEM conventions
See original GitHub issueI have been using your awesome library recently and have run into some issues with how the selectors architected. Classes like .button can cause a mess when you also have a standard .button component in your style sheet.
I propose to namespace all selectors for this library appropriately using BEM conventions. The root element should be .selectric and all other elements as .selectric__element-name. This would also require changes to the stylesheet.
Would you be interested in this contribution? I would be happy to take the time to put together a PR if it would be considered.
Issue Analytics
- State:
- Created 7 years ago
- Comments:6 (2 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
Yea, this would be a backwards-incompatible change, requiring a major version # bump.
It looks like most of the selectors are covered using the prefix option, however even if you use that option
.button,.label,.selected, and.lastare hardcoded classnames that float in the global namespace.I would recommend removing that functionality, I don’t think it is integral to this lib.
We ship it on v2.
It’s ok to not be backwards compatible.