search.on('end') fires before the entry is found

I’m using ldapjs client libraries to connect to an Active Directory server, everything works if the login succeeds and the user is found, but only if there’s no search.on(‘end’) specified. If I ad the ‘end’ listener, then it gets called BEFORE the user is found, so when I try to return the response, it crashes the app.

THIS DOESN’T WORK

            client.search('ou=users, dc=company, dc=com', opts, function(error, search) {
                    console.log('Searching.....');

                    search.on('searchEntry', function(entry) {
                        if (entry.object) {
                            userClient = ldap.createClient({url: config.ldap.url, timeout: 5000, connectTimeout: 10000});
                            userClient.bind(entry.object.dn, password, function(err) {
                                if (err == null) {
                                    res.send({status: "OK", sessionID: sessionID});
                                } else {
                                    res.send("FAIL - BAD LOGIN");
                                }
                            });
                        }
                    });

                    search.on('end', function(){
                        res.send("FAIL - not found");
                    });

THIS WORKS, BUT ONLY IF THE USER IS FOUND, IF NOT, APP CRASHES.

            client.search('ou=users, dc=company, dc=com', opts, function(error, search) {
                    console.log('Searching.....');

                    search.on('searchEntry', function(entry) {
                        if (entry.object) {
                            userClient = ldap.createClient({url: config.ldap.url, timeout: 5000, connectTimeout: 10000});
                            userClient.bind(entry.object.dn, password, function(err) {
                                if (err == null) {
                                    res.send({status: "OK", sessionID: sessionID});
                                } else {
                                    res.send("FAIL - BAD LOGIN");
                                }
                            });
                        }
                    });

All I want to do is return a failed login if the user does not exist on the server. And also determine if the login attempt failed by the password.

Any help would be greatly appreciated.

[maziyarpanahi]

here is how I did it. I have a login process as follow: search the LDAP and bind it. So either way I need the userObject or a null value to decide whether bind/search has failed:

let userObject = {};
    client.on('connect', function (e) {
        console.log('LDAP connected:');
        client.search(baseDN, opts, function(err, res) {
            res.on('searchEntry', function(entry) {               
                userObject = {
                    username: entry.object.uid,
                    firstname: entry.object.givenName,
                    lastname: entry.object.sn,
                    name: entry.object.cn,
                    email: entry.object.mail,
                    description: entry.object.description,
                    uidNumber: entry.object.uidNumber
                };
                client.bind(entry.object.dn, password, function(err, res) {
                    if(err){
                        // Bind failed, return null
                        callback(null);
                    }else{
                        // Bind was successful, return userObject                      
                        callback(userObject);
                    }
                });
            });
            res.on('searchReference', function(referral) {
                console.log('referral: ' + referral.uris.join());
            });
            res.on('error', function(err) {
                // client/TCP errors, return null
                callback(null);
            });
            res.on('end', function(result) {
                if(userObject.hasOwnProperty("username")){
                   // search was successful, will return null/objectUser in  client.bind
                  // no action needed here
                    console.log("finished success");
                }else{
                    // search failed, return null
                    callback(null);
                }
            });
        });
    });

I am using the latest version and res.end always returns null if it can’t find anything. I don’t really care if the search was successful as you can see. But the failed part always happens when the search fails. It’s unfortunate that in “search” the error is not the same as other functions:

Note that the error event will only be for client/TCP errors, not LDAP error codes like the other APIs

Hope this helps.

[victorbello]

I thought the same thing, but end fires before searchEntry even when there is a record found. I haven’t figured out a way to retrieve an login error with this library.