Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bugfix #6025 introduces exception in GridLayer._tileReady - a parameter check is missing

See original GitHub issue

Leaflet 1.3.2/1.3.3 has a fix that does not check a parameter for null/undefined and crashes in my scenario because GridLayer._tileReady(coords, err, tile) gets called with tile = null.

By fix #6025 GridLayer.js line 845 is changed to: if (!this._map || tile.getAttribute('src') === Util.emptyImageUrl) { return; } but tile is not checked. I propose fixing this by if (!this._map || (tile && tile.getAttribute('src') === Util.emptyImageUrl)) { return; }

I fear I can’t give a fiddle because I have a complicated scenario involving a subclassed leaflet.vectorgrid. The code worked fine with Leaflet 1.3.1 that didn’t have the second condition in the if statement.