Generic approach for popup.update() if content is still loading?

Hi Mourner,

this is a follow up ticket to https://github.com/Leaflet/Leaflet/issues/1959 and https://github.com/Leaflet/Leaflet/issues/2079 in which you refer to the popup.update()-function for reloading the popup in order to make autopanning work even if content is still loading.

I am having more and more users of my plugin pointing to that issue, e.g. http://www.davidkneale.com/wc2/destinations/borneo/ - unfortunately I did not find a generic solution for that issue yet.

To be more precise, I do not know how and when to execute that update()-function, as it should only be fired when content is still loading right?

I though about adding

marker.on('popupopen', function(e) { popup.update(); });

but that will not take into account if the content is still loading right? I thought in order for this to work, there needs to be an event which fires when popup content has been loaded, so that I can use this one for updating the popup content and fix autopanning. So I was looking for something like

marker.on('popup-loading-finished', function(e) { popup.update(); });

Unfortunately I couldnt find a similar event on your reference page. Could you please give me some hint on how this could be achieved?

Thx,

Robert

[ghybs]

Hi @schmidtster,

It sounds to me that you would be interested in the solution described in https://github.com/Leaflet/Leaflet/issues/5484#issuecomment-299949921 If still needed, please feel free to submit a PR for minHeight.

[cmwright93]

Hi ghybs

Thanks for getting back to me. I have tried that solution, the break ( popup._updated = true) does help with the solution’s infinite loop issue but unfortunately makes the overall function no longer work for its intended use.

On Fri, Dec 14, 2018 at 3:37 PM ghybs [e-mail] wrote:

Hi @cmwright93 https://github.com/cmwright93,

Have you tried the solution on the link https://stackoverflow.com/questions/51732698/leaflet-popup-update-resizing-solution-recreating-a-popup-everytime-unable/51749619#51749619 posted in #5484 (comment) https://github.com/Leaflet/Leaflet/issues/5484#issuecomment-299949921?

Should you need further help, please use Stack Overflow https://stackoverflow.com/questions/tagged/leaflet or GIS Stack Exchange https://gis.stackexchange.com/questions/tagged/leaflet.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Leaflet/Leaflet/issues/2739#issuecomment-447472486, or mute the thread https://github.com/notifications/unsubscribe-auth/AqPvHPm5v9UUNMUIeNS42LNOtANUjwtCks5u5AwFgaJpZM4CE4Dr .

–

Caroline Wright