.getBounds().pad() not working with negative values

This referes to a 2 year old issue found here: https://github.com/Leaflet/Leaflet/issues/2673

The problem: When passing negative values into the .pad() function, the result is not smaller than the current map container (-10 and 10 produce results that differ only slightly in size, but are both bigger than the map)

Steps to reproduce: Open the leaflet homepage map

Enter:

L.rectangle(map.getBounds().pad(-10)).addTo(map)
L.rectangle(map.getBounds().pad(10)).addTo(map)

into the console

Zoom out, see two rectangles bigger than the actual map at the time of drawing.

[IvanSanchez]

I don’t think this is a bug, it’s just a misunderstanding of what the method does, and the fact that we are using the word “percentage” in the docstrings rather than “ratio”.

Some clarification in the docstrings for that method (e.g. Returns bigger bounds created by extending the current bounds by a given ratio in each direction. For example, a ratio of 0.5 extends the bounds by 50%. Negative values yield smaller bounds instead. or something like that) would prevent this confusion in the future.

@CalvinWilliams1012, maybe you would like to make such a change in the documentation?

[IvanSanchez]

@CalvinWilliams1012 I think #5748 looks good enough. You can always run jake docs to build the documentation and check for yourself 🙂