Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

i18n - label for popup close button

See original GitHub issue

Checklist

I’ve searched through the plugins to make sure this feature isn’t already available, or think it shouldn’t require a plugin.
I’ve searched through the current issues to make sure this feature hasn’t been requested already.
I agree to follow the Code of Conduct that this project adheres to.

Motivation

I don’t see an easy way of setting aria-label value for popup close button. It seems like it’s hardcoded as Close popup.

Alternatives considered

No response

Issue Analytics

State:
Created a year ago
Comments:11 (5 by maintainers)

Top GitHub Comments

1reaction

Falke-Designcommented, Nov 17, 2022

@ChabbehAymen there is already a Pull Request for this #8590

1reaction

ShivangMishracommented, Oct 18, 2022

I think it would make sense to add this as a field to the popup options. Something like closeButtonLabel.

I’ve done it already yesterday . Please see my PR #8590

Top Results From Across the Web

Buttons - Menus and actions - Human Interface Guidelines

A button always includes a text label or a symbol (or interface icon) — and ... can configure them to behave like push...

Close button in modal alert is appearing for a fra... - ServiceNow

Hi Team, We are hiding OOB Cancel button on spModal alert which is appearing for fraction of seconds when we close the modal....

GWT Close button in title bar of DialogBox - Stack Overflow

This allows you to put it in the body of the dialog as far as the DOM is concerned, but make it physically...

I18n Guide for developers - Community Plugins - Ignite Realtime ...

This will make it nearly impossible to translate the i18n file without looking ... RMB-popupmenu.button-close=Quit ### keep the change log in SVN and...

Autocomplete API - Material UI - MUI

Name Type Default options * array renderInput * func autoComplete bool false