Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

L.Browser.pointer value is wrong

See original GitHub issue

Here are both docs and code: https://github.com/Leaflet/Leaflet/blob/d1a1e97b8290f642eb677284af53c2db64199a76/src/core/Browser.js#L94-L96

It is clearly seen that pointer value will be false in webkit despite docs statement.

The issue appeared after #6855.

I understand that PR purpose, but still insist that proposed fix was not proper.

webkit is not iOS-specific property. safari is more close, but still, that was not proper place to make that fix.
Perhaps this place is better to check for safari: https://github.com/Leaflet/Leaflet/blob/d1a1e97b8290f642eb677284af53c2db64199a76/src/map/handler/Map.Tap.js#L131-L136 At least change here would be more local.
Enabling tap handler indeed fixes issue with contextmenu event (though not completely: #6865), but it also has unwanted sideeffects. Sample to reproduce issues involves Leaflet.draw, which is old, unsupported,and need to be fixed itself. But if it is relevant - I can setup a fiddle.

Issue Analytics

State:
Created 4 years ago
Reactions:7
Comments:6 (2 by maintainers)

Top GitHub Comments

1reaction

johnd0ecommented, Jan 22, 2020

IvanSanchez changed the title L.Browser.pointer value is wrong for iOS safari

Title change of this issue is wrong, as it is related to any webkit-based browser, including desktop Chrome and android webview.

0reactions

johnd0ecommented, Mar 16, 2020

… any iOS devices to test this and #6865 and related issues.

Mentioned issue is not related to leaflet code changes.

Top Results From Across the Web

c++ - when assigning value to a pointer: Expression must be a ...

ERROR: expression must be a modifiable lvalue. In my case, p1 is not a local variable but a certain member of an object....

466874 - Mouse pointer location doesn't match blink hit-test ...

After scrolling and then touching the browser scrollbar , the page jumps to the correct|wrong position. ... Tried several recent Chromium builds, can't...

cursor - CSS-Tricks

The cursor property in CSS controls what the mouse cursor will look like when it is located over the element in which this...

Pointer events - Web APIs | MDN

The value manipulation means the browser may consider touches that begin on the element are only for scrolling and zooming. In the following ......

Indirection Operator: * | Microsoft Learn

If it points to a storage location, the result is an l-value designating the ... If the pointer value is invalid, the result...