L.Map.fitBounds() with invalid bounds error message could be better

Uncaught TypeError: Cannot read property 'lat' of undefinedo.LatLngBounds.getNorth @ leaflet.js:6o.LatLngBounds.getNorthWest @ leaflet.js:6o.Map.o.Class.extend.getBoundsZoom @ leaflet.js:6o.Map.o.Class.extend.fitBounds @ leaflet.js:6wikibase.queryService.ui.resultBrowser.CoordinateResultBrowser.SELF.draw @ CoordinateResultBrowser.js:64(anonymous function) @ App.js:411

http://tinyurl.com/jbxrwlv

[ghybs]

Hi,

It is true that it is strange to perform a sanity check (introduced by PR https://github.com/Leaflet/Leaflet/pull/4353) before _getBoundsCenterZoom, which does its own conversion to LatLngBounds and even accepts an object with getBounds method (e.g. a Feature Group, an Image Overlay, a Polyline / Polygon / Rectangle, or a Circle), even though this is not documented in the public API.

The preceding conversion to LatLngBounds (introduced by PR https://github.com/Leaflet/Leaflet/pull/4375) is similarly strange, since it duplicates this conversion, while being less permissive.

Finally, flyToBounds also makes use of _getBoundsCenterZoom but does not implement those 2 modifications, which is inconsistent.

Therefore it seems to me that if this were to be changed, it would be more consistent to implement the sanity check directly within _getBoundsCenterZoom, so that all public methods that use it can benefit, and it also avoids the double / less permissive conversion.

That being said, I do not see how any of this code can work with an array of markers. Were you referring to a Feature Group?

[andrzej-wisla]

Uncaught Error: fitBounds: latLngBounds must be of type LatLngBounds. What does it means ?