question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Reorganize versions, publish 1.0 supported version on npm

See original GitHub issue
  • The most current version of markercluster on npm is from two years ago, has version number 0.4.0.
  • It doesn’t support Leaflet 1.0 and ends in a cryptic messages of Trim not supported on undefined. This is the root cause of https://github.com/Leaflet/Leaflet/issues/4422 which no one knew why is happening. (and also https://github.com/Leaflet/Leaflet/issues/2408)
  • The readme says user should use bower, yet bower is discouraged by current Leaflet recommendations.
  • The 1.0 supporting master is still on 0.4.0 version number, just like the old 0.7 build.
  • The 0.7 branch is on 0.5.0 version (!), which is also what you get on bower.
  • brainmelt 😦

We should discuss how to handle markercluster, since it’s an official repo and has 1400+ stars.

As a temp workaround I published a “built” branch, so users can just use:

"leaflet.markercluster": "hyperknot/Leaflet.markercluster#built"

in their package.json to support Leaflet 1.0. Ideally something like this should be pushed on npm with version number 0.6.0 or something.

@mourner @perliedman @IvanSanchez @yohanboniface What do you think we should do?

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:7 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
danzelcommented, Apr 26, 2016

Ok, think this is all done now 😃

0reactions
almereydacommented, May 1, 2016

Also in a way the increase represents a breaking change within the lineup of releases, which is justified by a semantic versioning approach.

On 26 April 2016 at 07:53, Yohan Boniface notifications@github.com wrote:

Excellent, thanks @danzel https://github.com/danzel 😃

I’m not sure we should be matching leaflet version numbers, as when we change things we will want to bump our version number, and then we won’t line up.

Agreed! But I think bumping to 1.0.0 make sense for this long used plugin 😃 But then I agree plugins should not follow leaflet version number.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/Leaflet/Leaflet.markercluster/issues/666#issuecomment-214623172

Read more comments on GitHub >

github_iconTop Results From Across the Web

Updating your published package version number - npm Docs
Go to your package page ( https://npmjs.com/package/<package> ) to check that the package version has been updated. For more information on npm version...
Read more >
How to Use Semantic Versioning in NPM | heynode.com
Learn Semantic Versioning (SeVer) including package version management, how packages and dependencies are versioned in NPM, and preventing dependency drift.
Read more >
release management - Publishing versions out of order
[npm-publish] Fails if the package name and version combination already exists in the specified registry. Once a package is published with a ...
Read more >
npm packages in the Package Registry - GitLab Docs
Watch a video demo of how to publish npm packages to the GitLab Package Registry ... If multiple packages have the same name...
Read more >
npm Blog Archive: npm@2.0.0
Every week, we publish the new version to the next dist-tag. ... the behavior of version ranges using ^ , and only for...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found