question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Released JS in download ZIP has incorrect tag+commit reference

See original GitHub issue

How to reproduce

  • Leaflet version I’m using: 1.3.1
  • Browser (with version) I’m using: N/A
  • OS/Platform (with version) I’m using: N/A
  • step 1: download the v1.3.1 ZIP file from the official Leaflet download page.
  • step 2: extract the archive and inspect the content of the JS files (SRC and minified).

What behaviour I’m expecting and which behaviour I’m seeing

  • Expected: the tag+commit reference in the introductory comment/description should mention only 1.3.1 (i.e. release tag), and be absolutely identical to what is committed in the v1.3.1 release tag and published on npm (and accessible through unpkg CDN).
  • Actual: the tag+commit reference is 1.3.1+Detached: ba6f97fff8647e724e4dfe66d2ed7da11f908989.ba6f97f, the file having probably been automatically built without the NODE_ENV=release environmental variable.

The only difference between the file in the downloadable ZIP and the one in the tag (which is identical in npm and unpkg) is the version reference in the introductory comment and in the version property ("1.3.1+HEAD.ba6f97f" v.s. expected "1.3.1").

Minimal example reproducing the issue

N/A

As mentioned at https://stackoverflow.com/questions/48832378/why-does-leaflet-js-1-3-1-differ-between-unpkg-com-and-leafletjs-com

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:1
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
mournercommented, Dec 2, 2021

@Falke-Design pretty sure this will be fixed for the next release now that #7727 is merged. The detached head situation happened because the release script created an additional commit that added built files to git, which, as far as I remember, was introduced for the now-defunct Bower package manager.

0reactions
Falke-Designcommented, Dec 1, 2021

@mourner this is not fixed for the zip 1.7.1 (the minified version is correct but not the the -src file), is this solved for the 1.8.0 release?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Download zip release from private repository with node.js
You can use the Download repository archive (zip) endpoint, documented here. Take into consideration the following:.
Read more >
Release notes - DOMINO SUPPORT
A Relaunch button has been added to the Workspaces dashboard. You can use this button to launch a new Workspace session based on...
Read more >
Releases - GitLab Docs
GitLab automatically creates a JSON file that lists everything in the release, so you can compare and audit releases. This file is called...
Read more >
Carthage Tutorial: Getting Started - RayWenderlich.com
In this Carthage tutorial, you'll learn what Carthage is, how to install it and how to use it to declare, install and integrate...
Read more >
Changelog - Sourcegraph docs
Webhooks have been overhauled completely and can now be found under Site admin > Repositories > Incoming webhooks. Webhooks that were added via...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found