Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Use `<button>` for controls
See original GitHub issueIs your feature request related to a problem? Please describe.
<button> behaves a bit differently from <a href="#" role="button">, this would supersede https://github.com/Leaflet/Leaflet/issues/7368 and https://github.com/Leaflet/Leaflet/issues/7369 (these describe some of the problems with <a> controls).
Describe the solution you’d like
Use <button type="button"> over <a href="#"> for controls.
Additional context
Use buttons, not links, for controls
Agreed!
_Originally posted by @mourner in https://github.com/Leaflet/Leaflet/issues/3210#issuecomment-73291846._
we should use the button element here
This would be a breaking change we can make in Leaflet 2.
_Originally posted by @jonkoops in https://github.com/Leaflet/Leaflet/issues/7368#issuecomment-976742275._
Issue Analytics
- State:
- Created 2 years ago
- Reactions:3
- Comments:5 (3 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
I’ve created a label to keep track of breaking changes like these.
@Chi-teck The buttons would have accessible names as they have now. This issue is about the elements themselves.
An
aria-labelto give the popup close button a proper accessible name was fixed in #7794.