Play 2.6 - users may still use the depracated Action

Hi,

Despite the library now compiling without warnings, users that use it may still run into depracated warnings whenever they use it:

import mockws.MockWS
import play.api.mvc.Results.Ok
import play.api.mvc.Action
val ws = MockWS {
  case (GET, "http://www.example.com") => Action { Ok("homepage") }
}

Will cause:

Warning:(30, 49) object Action in package mvc is deprecated (since 2.6.0): Inject an ActionBuilder (e.g. DefaultActionBuilder) or extend BaseController/AbstractController/InjectedController
        case (GET, "http://www.example.com") => Action { Ok("homepage") }

Maybe it’s a good idea to provide a helper action that the users can import and use without warnings:

import play.api.mvc.{AnyContentAsEmpty, DefaultActionBuilder}
import play.api.test.Helpers.stubBodyParser
import scala.concurrent.ExecutionContext
object MockWS {
  val Action: DefaultActionBuilder = DefaultActionBuilder(stubBodyParser(AnyContentAsEmpty))(ExecutionContext.global)
}

[raphaelbauer]

Hi @yanns here’s a sketch: https://github.com/leanovate/play-mockws/pull/30 Feedback welcome! Thanks, Raphael

[francisdb]

this is how we currently work around this for specs2

class UsingMockSpec(implicit ee: ExecutionEnv) extends Specification with FutureMatchers with ResultMatchers with MockHelper{
  // test code here
}

import akka.actor.ActorSystem
import akka.stream.ActorMaterializer
import org.specs2.specification.AfterAll
import play.api.mvc.{DefaultActionBuilder, PlayBodyParsers}

import scala.concurrent.Await
import scala.concurrent.duration._

/**
  * See https://github.com/leanovate/play-mockws/issues/29
  */
trait MockHelper extends AfterAll{
  private implicit val sys = ActorSystem("test")
  private implicit val mat = ActorMaterializer()

  val BodyParser: PlayBodyParsers = PlayBodyParsers()
  val Action: DefaultActionBuilder = DefaultActionBuilder(BodyParser.anyContent)(mat.executionContext)

  override def afterAll = {
    mat.shutdown()
    Await.result(sys.terminate(), 10.seconds)
  }
}