question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Create new base top bar component with mobile responsive breakpoints

See original GitHub issue

Overview: The new top bar component should replace the current duplicated title, and there should be no in-page resource title. The top bar is not sticky and has new mobile responsive breakpoints.

Done when:

  • Top bar replaces current layout and correctly renders title metadata
  • Top bar correctly displays the correct layout of icons (placeholder icons okay if this a bottleneck, but please add a code comment TODO that can be checked for later and note in the PR) and menu options based on new breakpoints
  • Top bar renders new tooltips with strings on hover for all icons and menu options

Beyond scope of this ticket:

  • Menu interactions working
  • Top bar fully implemented in all places where it is used
  • Status/progress indicators

Figma references: Screen Shot 2021-05-25 at 10 05 54 AM Screen Shot 2021-05-25 at 10 01 00 AM Screen Shot 2021-05-25 at 10 00 51 AM Screen Shot 2021-05-25 at 10 00 00 AM

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
nucleogenesiscommented, Jun 1, 2021

@MisRob @marcellamaki

Top bar fully implemented in all places where it is used

This is kind of a built in if you update the existing component I think. It doesn’t seem like we’d need a separate version of the component to handle the updates.

Just want to note that we currently use ImmersiveToolbar to handle the top bar when viewing a resource.


I think that the context menu shouldn’t be implemented at all for acceptance of this since none of the functionality there in can be hooked up. In this case a follow-up issue could be created and the work here could be simplified a little bit (who knows the requirements for that form might change so why make it a requirement if it’s not actually fully designed and planned?).

I’ll get #8095 for the bookmarks done today so you can have that available.


@khangmach what does “View Lesson Plan” do? When does it show - only when the user entered the resource from a lesson or if the resource is in any lesson? What if the resource is in multiple lessons?

0reactions
MisRobcommented, Jun 3, 2021

@marcellamaki:

It’s fine to proceed as is, and focus mostly on the UI aspects of the feature as originally described in the ticket

I’m continuing my work on this

Read more comments on GitHub >

github_iconTop Results From Across the Web

Building Responsive Apps with Base Web
Tips and tricks for building responsive apps for mobile and desktop using Base Web.
Read more >
Breakpoints | Webflow University
To add a breakpoint, click the breakpoint dropdown (to the left of the desktop icon in the top toolbar) and choose from the...
Read more >
Creating a Responsive Layout in React - Telerik
In this tutorial we will use Flexbox, some basic media queries to create breakpoints determining how to render our layout. I have a...
Read more >
Responsive web design basics
Responsive web design basics ; Set the viewport. Ensure an accessible viewport ; Size content to the viewport. Images; Layout ; Use CSS...
Read more >
Building a responsive navbar in Tailwind CSS - LogRocket Blog
Learn how to build a responsive navbar for desktop, tablets, and mobile in Tailwind without touching a line of CSS.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found