In TextTruncator, allow an option to apply the "shave" only if the amount of text that will be hidden is substantial

Observed behavior

In the implementation of TextTruncator, we always truncate the text if the text will exceed a certain max height prop.

In some cases, this leads to a situation where 75% of a paragraph is shown and the last 25% is hidden. It might have been better just to show the whole paragraph and spare the user from clicking a button to see the rest.

Example: (3 lines shown, 1 line hidden)

Expected behavior

For certain situations, do not trim the text esp. if the untrimmed text is not that much bigger.

User-facing consequences

…

Errors and logs

…

Steps to reproduce

…

Context

…

[jonboiser]

Oh, that’s interesting. I didn’t notice that was done in that commit.

The showViewMore in RecommendedPage/ContentCardGroupHeader is not used as a prop in TextTruncator (they just have the same name by coincidence).

I need to look into this, but I think if https://github.com/learningequality/kolibri/commit/a1f37830fd1d55043867b3338a357fa05c604ced#diff-98afdf62d41fff77bd66c302cf23e1bcf8aa203c53049d27b81699e9db5a622fL57 removed TextTruncator from the topics pages, then that actually resolves the problem that prompted me to write this issue.

I think I should just close this issue for now, unless you have a good idea on how to implement this new feature.

If you are interested, this issue https://github.com/learningequality/kolibri/issues/7557 is much more important and affects the majority of places where we use TextTruncator without the showViewMore prop.

[jonboiser]

@Kalovelo , yes, any help on this issue would be appreciated.