question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Insufficient options for correct i18n in AssignmentChangeStatusModal

See original GitHub issue

Observed behavior

When observed in UI language with gendered adjectives as Spanish, option labels in the status change modal for Lessons and Exams will always display incorrectly in one of those two.

At first I thought it was my error while translating, but after digging deeper, it seems to be more than that. If I’m interpreting the code correctly, the AssignmentChangeStatusModal.vue component is (re)used in both cases, even though in languages other than English, Lessons and Exams might be adjectives of different genders. In Spanish Lesson is Activa but Exam is Activo.

selection_005

I can appreciate the “reuse” philosophy, but in this case the result is too DRY for the correct i18n. Since we are past the string freeze, I’ve changed the translation on Crowdin to verbs (Activar/Desactivar), and my suggestion is to do the same for the next release, namely, make the following change:

      activeOption: 'Activate',
      inactiveOption: 'Deactivate', 

Not much we can do in the assignments/StatusIcon.vue at this point, but it is probably going to need to get a bit wet in the future.

User-facing consequences

Incorrect UI text that reduces understanding.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:1
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
radinamaticcommented, Sep 20, 2018

@DXCanas You are right, that version of the translation is suboptimal too. That’s why I suggested the verb form, and in fact in latest translation QA round I changed it to Activar/Desactivar, since, as you point out, we do title the modal Cambiar el estado de lección (Change the lesson status), that is, we demand an action from the user, which would indicate that the verb is more appropriate.

0reactions
indirectlylitcommented, Sep 20, 2018

(cc @jtamiace)

Read more comments on GitHub >

github_iconTop Results From Across the Web

Rails Internationalization (I18n) API - Ruby on Rails Guides
This guide will walk you through the I18n API and contains a tutorial on how to internationalize a Rails application from the start....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found