Insufficient options for correct i18n in AssignmentChangeStatusModal
See original GitHub issueObserved behavior
When observed in UI language with gendered adjectives as Spanish, option labels in the status change modal for Lessons and Exams will always display incorrectly in one of those two.
At first I thought it was my error while translating, but after digging deeper, it seems to be more than that. If I’m interpreting the code correctly, the AssignmentChangeStatusModal.vue
component is (re)used in both cases, even though in languages other than English, Lessons and Exams might be adjectives of different genders. In Spanish Lesson is Activa but Exam is Activo.
I can appreciate the “reuse” philosophy, but in this case the result is too DRY for the correct i18n. Since we are past the string freeze, I’ve changed the translation on Crowdin to verbs (Activar/Desactivar), and my suggestion is to do the same for the next release, namely, make the following change:
activeOption: 'Activate',
inactiveOption: 'Deactivate',
Not much we can do in the assignments/StatusIcon.vue
at this point, but it is probably going to need to get a bit wet in the future.
User-facing consequences
Incorrect UI text that reduces understanding.
Issue Analytics
- State:
- Created 5 years ago
- Reactions:1
- Comments:7 (7 by maintainers)
Top GitHub Comments
@DXCanas You are right, that version of the translation is suboptimal too. That’s why I suggested the verb form, and in fact in latest translation QA round I changed it to
Activar/Desactivar
, since, as you point out, we do title the modalCambiar el estado de lección
(Change the lesson status), that is, we demand an action from the user, which would indicate that the verb is more appropriate.(cc @jtamiace)