New CoreBase

Context

EDIT: No more borrowing PageRoot - let’s make a new component altogether.

In order to begin updating Kolibri’s many plugins and uses of CoreBase, we must establish a new component built to our new ideals that we can start implementing without regressions.

My suggestion is to take create a new component for this purpose. This will give us a component that accommodates the following suggestions:

• The GlobalSnackbar component should be loaded into every page. This means that the GlobalSnackbar can show itself anytime it sees the correct Vuex state.
• The Core Vuex store’s error state property is universally how we will decide if the user should see one of either an AuthMessage error message or a general AppError message.
• The UpdateNotification component should be available on every page (and, naturally, rendered under the correct circumstances)
• Renders, otherwise, only a default slot, into which any implementing page in the app can display what they need to.

Acceptance Criteria

• Create a new root component, include it in the apiSpec
• Move the four aforementioned components to the new component. The error components should follow a similar logical flow as in CoreBase. The other two components need be loaded into the app.
• The component should render the default slot when there are no errors.
• Unit tests covering conditions for showing error messages vs router view

[nucleogenesis]

Thanks Misha - I closed the issue mostly because I didn’t want to have it assigned to someone during the sprint planning before I fully grokked your comments.

I will update the router-view requirement to instead suggest a default slot.

In follow-up issues, then, such as “remove CoreBase from LearnIndex” the requirements will have the router-view put into that slot.

[MisRob]

@nucleogenesis Although the reasoning behind touches on more aspects of the high-level architecture, in terms of this particular issue it was basically all related to the last requirement only, so if that makes sense, I think it’d be also fine to just remove

Renders, otherwise, only a RouterView, into which any implementing page in the app can route their behavior through.

and maybe mention a bit about how we will use this component from other components instead. Whatever will work for you, just wanted to note that I don’t think that the whole issue doesn’t make sense.