Numerals are not localized in some places (and use 0-9 arabic numerals by default)
See original GitHub issueObserved behavior
Here are places on https://kolibri-beta.learningequality.org/mr that I was able to find (annotations are within the screenshots)
Version numbers on https://kolibri-beta.learningequality.org/mr/device/#/content
Number of learners in class on https://kolibri-beta.learningequality.org/mr/facility/#/a3f606630690237bbe94fe2a1a850af4/classes
KTextbox maxlength validations
Time elapsed messages on various Coach Pages https://kolibri-beta.learningequality.org/mr/coach/#/10c12cbfc4b67630511d67f7b7895f17/reports/quizzes/70a26038f8dddffcb93f05bcec8b2095/learners (same on lessons pages)
Birth years on profile page and other places
Expected behavior
If appropriate, numerals should use the Intl API’s number formatter, so numbers in e.g. the Marathi (mr) locale use those numerals consistently and so on.
User-facing consequences
…
Errors and logs
…
Steps to reproduce
…
Context
…
Issue Analytics
- State:
- Created 3 years ago
- Comments:8 (8 by maintainers)
Top GitHub Comments
I think this might depend on the situation. I really think that if a number is just by itself in the template, we should be using the
$formatNumber
method instead of using$tr('integer', ...)
. Could you see if that approach works?Here are the doc explaining how
$formatNumber
works. https://github.com/learningequality/vue-intl#instance-methodsIt is like a wrapper around
Intl.NumberFormat
@Kalovelo , I just checked to see if the the Intl API for datetimes localized calendar dates for Marathi, and they do. So please include the User Profile pages that display birth year. I believe the component is
BirthYearDisplayText.vue