question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update messages for filters on CoachExamsPage (and lessons too)

See original GitHub issue

I spotted this while reviewing #9863 and saw some linting changes in the diff for CoachExamsPage where there are comments indicating that we were temporarily commenting out the Active/Inactive filters for exams in #6174 due to not having updated the strings.

With the guidance from @radinamatic in #6174 we need to be sure we have the correct strings defined in the component and that the select dropdown is visible and working as expected.

Note that CoachExamsPage isn’t the only place where this is an issue, there are others as can be seen in https://github.com/learningequality/kolibri/pull/6233/files (the PR that commented the filters out).

Issue Analytics

  • State:open
  • Created 10 months ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
radinamaticcommented, Dec 16, 2022

This will work very well @jtamiace @akolson 💯

Let’s just make sure we put the proper context for translators:

filterLessonStatus: {
        message: 'Status',
        context: 'Label for the selector used to filter and display lessons by status.',
      },

---

filterLessonAll: {
        message: 'All',
        context: 'Refers to LESSON. Default option in the selector used to filter and display lessons by status. ',
      },

---

filterLessonVisible: {
        message: 'Visible',
        context: 'Refers to LESSON. Option in the selector used to filter and display only the lessons visible  to learners. ',
      },

…and so forth 🙂

0reactions
akolsoncommented, Dec 16, 2022

@jtamiace Thanks for the design insights. This below seems more consistent with other filters in Kolibri and I think is a better option to pursue.

For lessons: Filter label: Status Options: All, Visible, Not visible

For quizzes: Filter label: Status Options: All, Not started, Started, Ended

@radinamatic any concerns regarding i18n?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Create rules to filter your emails - Gmail Help - Google Support
Click Filter messages like these. Enter your filter criteria. Click Create filter. ... Open Gmail. ... See all settings. Click Filters and Blocked...
Read more >
How to use Gmail Filters like a Pro! (Tutorial) - YouTube
Gmail filters can make managing your email so much easier! In just a few clicks, filters can bring your Gmail inbox under control...
Read more >
SMS and MMS Message Filtering - Apple Developer
Create an app extension that identifies and filters unwanted SMS and MMS messages while preserving user privacy.
Read more >
Search and filter messages - Microsoft Support
Find and filter messages with the Search bar in Microsoft Teams. Try it! Search for a message. Select the Search bar at the...
Read more >
Filter messages from a subscription | Cloud Pub/Sub
You can filter messages by their attributes, but not by the data in the message. ... All subscribers can receive messages from subscriptions...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found