Get rid of SUPPORTED_HARDWARE_LIST
See original GitHub issueProblem
Maintaining that list is burden you don’t really want to have. New devices will be released and other manufacturers will release compatible devices.
Proposal
If device is discovered from Foyer API, it’s probably good. Then we can check if it returns alarms list correctly, otherwise mark sensor unavailable
.
Issue Analytics
- State:
- Created 3 years ago
- Comments:11 (3 by maintainers)
Top Results From Across the Web
Safely remove hardware in Windows - Microsoft Support
Safely remove hardware in Windows ; Start > ; Settings > Devices. Select the device, and select Remove device.
Read more >Add or remove trusted computers - Google Account Help
Remove computers & devices from your trusted list. On your Android phone or tablet, open your device's Settings app and then Google and...
Read more >View and remove your devices that are associated with Apple ...
View and remove your devices that are associated with Apple ID purchases. Manage the list of devices that can download and play items...
Read more >How to Remove Devices from the Devices List - Central Support
You can remove devices from the Devices list. In Central, go to the Configuration > Devices menu. Click Remove from list next to...
Read more >Disabling the Ubisoft Connect overlay
Under the General tab, uncheck Enable in-game overlay for supported games. ... that blocked friends will remain on your friends list unless you...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Yeh, unfortunately, i don’t think we can use those homegraph docs. Our two probably most possible options I see here are either have and maintain
SUPPORT_HARDWARE_LIST
or drop it and in the update cycle:unavailable
;self.google_devices
(list of devices cached for as long as the tokens are valid ~22h) we loop through devices excludingunavailable
devices and logging those asDEBUG
.Hmmmm, the reason I though of adding it is that i have a few chromecasts at home that fail return timers/alarms since they don’t have them. But now that we ‘cache’ google devices locally and only update that list once in a while (when we need to refresh tokens or on the restart), we could mark those devices as
unavailable
as you proposed and skip updating everyUPDATE_PERIOD
.