question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Get rid of SUPPORTED_HARDWARE_LIST

See original GitHub issue

Problem

Maintaining that list is burden you don’t really want to have. New devices will be released and other manufacturers will release compatible devices.

Proposal

If device is discovered from Foyer API, it’s probably good. Then we can check if it returns alarms list correctly, otherwise mark sensor unavailable.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:11 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
leikoiljacommented, Mar 9, 2021

Yeh, unfortunately, i don’t think we can use those homegraph docs. Our two probably most possible options I see here are either have and maintain SUPPORT_HARDWARE_LIST or drop it and in the update cycle:

  • fetch all google devices
  • fetch alarms/timers for each of the devices; catch 404 for those which devices are not supported and mark them as unavailable;
  • before setting self.google_devices(list of devices cached for as long as the tokens are valid ~22h) we loop through devices excluding unavailable devices and logging those as DEBUG.
1reaction
leikoiljacommented, Mar 8, 2021

Hmmmm, the reason I though of adding it is that i have a few chromecasts at home that fail return timers/alarms since they don’t have them. But now that we ‘cache’ google devices locally and only update that list once in a while (when we need to refresh tokens or on the restart), we could mark those devices as unavailable as you proposed and skip updating every UPDATE_PERIOD.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Safely remove hardware in Windows - Microsoft Support
Safely remove hardware in Windows ; Start > ; Settings > Devices. Select the device, and select Remove device.
Read more >
Add or remove trusted computers - Google Account Help
Remove computers & devices from your trusted list. On your Android phone or tablet, open your device's Settings app and then Google and...
Read more >
View and remove your devices that are associated with Apple ...
View and remove your devices that are associated with Apple ID purchases. Manage the list of devices that can download and play items...
Read more >
How to Remove Devices from the Devices List - Central Support
You can remove devices from the Devices list. In Central, go to the Configuration > Devices menu. Click Remove from list next to...
Read more >
Disabling the Ubisoft Connect overlay
Under the General tab, uncheck Enable in-game overlay for supported games. ... that blocked friends will remain on your friends list unless you...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found