Installer broken with virtualenv 20.x

I tried installing Lektor on Linux via the installer script at https://www.getlektor.com/install.sh. This resulted in the following error messages:

/usr/bin/python: can't open file './src/virtualenv.py': [Errno 2] No such file or directory
/usr/bin/python: can't open file './virtualenv.py': [Errno 2] No such file or directory

It seems the internal structure of the virtualenv package changed again. If I modify the installer script to force an older version of virtualenv, it works again:

VENV_URL = "https://pypi.org/pypi/virtualenv/16.7.9/json"

[xlotlu]

Anyone up for making a PR?

I’ll do it.

[kodmasin]

No reason except I am more familiar with wget. Here is curl version:

--- install.sh	2020-03-16 00:31:08.799577500 +0100
+++ /mnt/e/programs/lektor/install.sh	2020-03-16 00:28:00.551836200 +0100
@@ -36,7 +36,7 @@
 
     sys.stdin = open('/dev/tty', 'r')
 
-    VENV_URL = "https://pypi.python.org/pypi/virtualenv/json"
+    VENV_URL = "https://bootstrap.pypa.io/virtualenv.pyz"
     KNOWN_BINS = ['/usr/local/bin', '/opt/local/bin',
                   os.path.join(os.environ['HOME'], '.bin'),
                   os.path.join(os.environ['HOME'], '.local', 'bin')]
@@ -114,17 +114,14 @@
 
     def install(virtualenv_url, lib_dir, bin_dir):
         t = tempfile.mkdtemp()
-        Popen('curl -sf "%s" | tar -xzf - --strip-components=1' %
+        Popen('curl -O "%s"' %
               virtualenv_url, shell=True, cwd=t).wait()
 
         try:
             os.makedirs(lib_dir)
         except OSError:
             pass
-        try:  # virtualenv 16.1.0, 17+
-            check_output([sys.executable, './src/virtualenv.py', lib_dir], cwd=t)
-        except CalledProcessError:  # older virtualenv
-            Popen([sys.executable, './virtualenv.py', lib_dir], cwd=t).wait()
+        Popen([sys.executable, './virtualenv.pyz', lib_dir], cwd=t).wait()
         Popen([os.path.join(lib_dir, 'bin', 'pip'),
            'install', '--upgrade', 'Lektor']).wait()
         os.symlink(os.path.join(lib_dir, 'bin', 'lektor'),
@@ -155,14 +152,7 @@
 
         if prompt: get_confirmation()
 
-        for url in json.loads(urlopen(VENV_URL).read().decode('utf-8'))['urls']:
-            if url['python_version'] == 'source':
-                virtualenv = url['url']
-                break
-        else:
-            fail('Could not find virtualenv')
-
-        install(virtualenv, lib_dir, bin_dir)
+        install(VENV_URL, lib_dir, bin_dir)
 
         print('')
         print('All done!')

Here is simple urlretrieve version also but it does not show download progress (for that it will be more complicated to solve python2/3 comaptibility issues):

--- install.sh	2020-03-15 23:50:37.555242800 +0100
+++ /mnt/e/programs/lektor/install.sh	2020-03-15 23:47:40.352555700 +0100
@@ -26,9 +26,9 @@
     import shutil
     from subprocess import CalledProcessError, check_output, Popen
     try:
-        from urllib.request import urlopen
+        from urllib.request import urlopen, urlretrieve
     except ImportError:
-        from urllib import urlopen
+        from urllib import urlopen, urlretrieve
 
     PY2 = sys.version_info[0] == 2
     if PY2:
@@ -36,7 +36,7 @@
 
     sys.stdin = open('/dev/tty', 'r')
 
-    VENV_URL = "https://pypi.python.org/pypi/virtualenv/json"
+    VENV_URL = "https://bootstrap.pypa.io/virtualenv.pyz"
     KNOWN_BINS = ['/usr/local/bin', '/opt/local/bin',
                   os.path.join(os.environ['HOME'], '.bin'),
                   os.path.join(os.environ['HOME'], '.local', 'bin')]
@@ -113,18 +113,26 @@
         sys.exit(1)
 
     def install(virtualenv_url, lib_dir, bin_dir):
-        t = tempfile.mkdtemp()
-        Popen('curl -sf "%s" | tar -xzf - --strip-components=1' %
-              virtualenv_url, shell=True, cwd=t).wait()
+	print('')
+	print("Fetching virtualenv ...")
+	urlfile = urlretrieve(VENV_URL)
+	print('')
+	print("virtualenv fetched")
+	t, vefile =os.path.split(urlfile[0])
 
         try:
             os.makedirs(lib_dir)
         except OSError:
             pass
-        try:  # virtualenv 16.1.0, 17+
-            check_output([sys.executable, './src/virtualenv.py', lib_dir], cwd=t)
-        except CalledProcessError:  # older virtualenv
-            Popen([sys.executable, './virtualenv.py', lib_dir], cwd=t).wait()
+	print('')
+	print("Creating Lektor virtualenv ...")
+	print('')
+        Popen([sys.executable, vefile, lib_dir], cwd=t).wait()
+	print('')
+	print("virtualenv created")
+	print('')
+	print("installing Lektor ...")
+	print('')
         Popen([os.path.join(lib_dir, 'bin', 'pip'),
            'install', '--upgrade', 'Lektor']).wait()
         os.symlink(os.path.join(lib_dir, 'bin', 'lektor'),
@@ -155,14 +163,7 @@
 
         if prompt: get_confirmation()
 
-        for url in json.loads(urlopen(VENV_URL).read().decode('utf-8'))['urls']:
-            if url['python_version'] == 'source':
-                virtualenv = url['url']
-                break
-        else:
-            fail('Could not find virtualenv')
-
-        install(virtualenv, lib_dir, bin_dir)
+        install(VENV_URL, lib_dir, bin_dir)
 
         print('')
         print('All done!')

I just tested this with python2 so I am not sure is it working with python3