Fantastic extension needs performance optimization

Issue Type: Performance Issue

Love this extension. Helps me visualize my position in code, especially in deeply nested widgets. But it’s lagging even on my high end device. Even at N6 it’s barely usable. Also I suspect it might have a memory leak, as it keeps getting worse and gets better after a a reload.

Extension version: 1.2.16 VS Code version: Code - Insiders 1.62.0-insider (4bbec283c36a51cf80f9b77c7a81c140a76a363b, 2021-11-02T08:19:40.220Z) OS version: Windows_NT x64 10.0.22000 Restricted Mode: No

System Info

Item	Value
CPUs	AMD Ryzen 9 4900H with Radeon Graphics (16 x 3294)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	31.42GB (12.52GB free)
Process Argv	–crash-reporter-id 76213229-3f45-4857-b470-1778a95699b5
Screen Reader	no
VM	0%

Process Info

CPU %	Mem MB	   PID	Process
    0	   137	  3956	code-insiders main
    0	    24	  9636	   crashpad-handler
    4	   217	 13612	   window (series_list_sort_section.dart - banagher - Visual Studio Code - Insiders)
   10	   256	 11588	     extensionHost
    0	     5	 19536	       C:\WINDOWS\system32\cmd.exe /d /s /c ""C:\flutter\bin\cache\dart-sdk\bin\dart.exe" "C:\flutter\bin\cache\dart-sdk\bin\snapshots\analysis_server.dart.snapshot" "--lsp" "--client-id=VS-Code" "--client-version=3.28.0""
    0	    11	  3876	         console-window-host (Windows internal process)
   12	    89	 25268	         "C:\flutter\bin\cache\dart-sdk\bin\dart.exe"  "C:\flutter\bin\cache\dart-sdk\bin\snapshots\analysis_server.dart.snapshot" "--lsp" "--client-id=VS-Code" "--client-version=3.28.0"
    0	     6	 29944	       C:\WINDOWS\system32\cmd.exe /d /s /c ""C:\flutter\bin\flutter.bat" "daemon""
    0	    11	 30516	         console-window-host (Windows internal process)
    3	   123	 30568	         "C:\flutter\bin\cache\dart-sdk\bin\dart.exe"  --disable-dart-dev --packages="C:\flutter\packages\flutter_tools\.packages"  "C:\flutter\bin\cache\flutter_tools.snapshot" "daemon" 
    0	     5	 30804	       C:\WINDOWS\system32\cmd.exe /d /s /c ""c:\Users\Agone\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\node_modules.asar.unpacked\vscode-ripgrep\bin\rg.exe" --no-messages --vimgrep -H --column --line-number --color never --max-columns=1000 --no-config  -f "c:\Users\Agone\AppData\Roaming\Code - Insiders\User\workspaceStorage\33938f9b144b76f96ab13177c795021d\Gruntfuggly.todo-tree\2hbwjcffks.txt" -g "!**/node_modules" -g "!**/banagher/windows/**/*" -g "!c:\Users\Agone\Source\work\comikey\banagher\lib\helpers\platform.dart" "c:\Users\Agone\Source\work\comikey\banagher""
    0	    11	 30204	         console-window-host (Windows internal process)
    0	     9	 32232	         "c:\Users\Agone\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\node_modules.asar.unpacked\vscode-ripgrep\bin\rg.exe"  --no-messages --vimgrep -H --column --line-number --color never --max-columns=1000 --no-config  -f "c:\Users\Agone\AppData\Roaming\Code - Insiders\User\workspaceStorage\33938f9b144b76f96ab13177c795021d\Gruntfuggly.todo-tree\2hbwjcffks.txt" -g "!**/node_modules" -g "!**/banagher/windows/**/*" -g "!c:\Users\Agone\Source\work\comikey\banagher\lib\helpers\platform.dart" "c:\Users\Agone\Source\work\comikey\banagher"
    0	     6	 32092	       "C:\Program Files\Git\cmd\git.exe" for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track) refs/heads/dev refs/remotes/dev
    0	    11	 28588	         console-window-host (Windows internal process)
    0	     0	 30500	         
    1	   469	 15708	   gpu-process
    0	    39	 25308	   utility
    7	   139	 30700	   shared-process
    0	    68	 13304	     ptyHost
    0	     7	 14368	       console-window-host (Windows internal process)
    0	    51	 26732	       "C:\Program Files\PowerShell\7\pwsh.exe"
    0	    88	 30924	     watcherServiceParcelSharedProcess
    0	    92	 31528	   window (Issue Reporter)
    0	     7	 32724	   "C:\Program Files\Google\Drive File Stream\52.0.6.0\crashpad_handler.exe" --database=C:\Users\Agone\AppData\Local\Google\DriveFS\Crashpad --url=https://clients2.google.com/cr/report "--annotation=application=Code - Insiders.exe" --annotation=prod=DriveFS --annotation=ver=52.0.6.0 --initial-client-data=0x15b0,0x15a4,0x1574,0x1594,0x1558,0x7ffce569f820,0x7ffce569f830,0x7ffce569f840

Workspace Info

|  Window (series_list_sort_section.dart - banagher - Visual Studio Code - Insiders)
|    Folder (banagher): 10689 files
|      File types: xml(2133) json(1217) flat(1056) svg(308) class(294)
|                  jar(219) png(178) dart(156) txt(126) len(123)
|      Conf files: cmake(12) sln(6) github-actions(1) launch.json(1)
|                  tasks.json(1)
|      Launch Configs: dart(4);

[leodevbro]

Good news, I discovered a great optimization trick in VSCode API. Basically, I can reuse most (like 90%) of the line blocks for rendering (In version 1.2.16, new HTML div is being created for each line, so it’s very slow), so in new version, only about 10% of the HTML divs will stress the CPU. Already tested it successfully. I’m not totally sure, but I am like 95% sure that the final code will be much faster. I’m going to release the new version soon, maybe tomorrow, or maybe the day after tomorrow.

[leodevbro]

Very cool, for me, the startup time was 921ms, but I guess it’s not a big deal even if it is 3 seconds or more. The big deal is how it performs during working process. I’m glad it performs better in your environment. I suggest to test it for several days more, and if we notice no degradation of speed, then we can close this issue.