Ryven not working with ryvencore

Hello,

It looks like Ryven doesn’t work anymore with the new interfaces of ryvencore.

Traceback (most recent call last):
  File "C:\git\Ryven\ryven\main\Ryven.py", line 105, in <module>
    run()
  File "C:\git\Ryven\ryven\main\Ryven.py", line 26, in run
    init_node_env()
  File "C:\git\Ryven\ryven\NENV.py", line 26, in init_node_env
    from ryvencore_qt import \
  File "C:\git\ryvencore-qt\ryvencore_qt\__init__.py", line 12, in <module>
    from .src.core_wrapper import *
  File "C:\git\ryvencore-qt\ryvencore_qt\src\core_wrapper\__init__.py", line 2, in <module>
    from ryvencore import InfoMsgs, NodeInputBP, NodeOutputBP, ExecConnection, dtypes, \
ImportError: cannot import name 'NodeInputBP' from 'ryvencore' (C:\git\ryvencore\ryvencore\__init__.py)

Do you have any plans to update it? I wanted to do some tests and possibly develop a node library. The improvements to ryvencore seem to be worth it, but without a working Ryven it’s a bit tough to get started!

[amaury-anciaux]

Ok that’s what I thought! I went through the changes as an exercise to better understand the project, but I can put together a PR to fix Ryven and ryvencore-qt so that it works with what you have in ryvencore on the dev branch. I need to work through the rest of the code base though, so am not exactly sure when I’ll be able to finish it.

[amaury-anciaux]

I went through some of the changes that are required to match the new ryvencore code. Broadly I saw:

1. Removal of Connection class
2. Removal of Script class reflected in json file format
3. VarsManager, LogsManager and DTypes becoming addons, DTypes removed from Nodes
4. Removal of node_view_placed event from Flow and view_place_event from Node
5. Other minor API changes such as removal of init_data field in Flow

I will continue to explore, but wanted to ask you:

• On (1) is it the goal to keep such a barebones interfaces as Tuple[NodeOutput, NodeInput]? I would agree with you that the original Connection object doesn’t add much on top, but that will delegate some of the work to calling functions e.g. in the form of working directly with graph_adj.
• On (4) can you explain the logic of removing view_place_event from Node? I could bring the virtual method in the Node wrapper, but want to make sure that it’s the right approach.

Thanks!