question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Font Awesome 5 support

See original GitHub issue

Hi! I would really love if you could make a small change to support Font Awesome version 5. The difference from version 4 is that now they generate a svg-tag instead of using the font-family.

Example Version 4: <i aria-hidden="true" class="fa fa-caret-down"></i> & with the css looking something like this: .fa-caret-down:before { font-family: FontAwesome; content: "\f107"; }

Version 5: <svg aria-hidden="true" class="svg-inline--fa fa-caret-down fa-w-10" data-prefix="fa" data-icon="caret-down" role="img"> <path fill="currentColor" d="M31.3 192h257.3c17........"></path> </svg> <!-- <i aria-hidden="true" class="fa fa-caret-down"></i> -->

So they´re commenting away the <i></i> tag when generating the svg, which leads to that the carets in your treeview is not working.

Thanks for your quick support.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:1
  • Comments:20 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
nheath99commented, Jun 7, 2018

@leovo2708 I agree with @ida-e, this is fully compatible with FontAwesome 4.

1reaction
nheath99commented, Jun 5, 2018

Thanks. It is very simple; I have created a pull request: #151 I have also changed lines 32-33 with the same principles. Please add any comments.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Get the dev and design support you need - Font Awesome
Yes, Font Awesome 5 is officially supported until we announce otherwise. However, all new icons, features, and services will be under the umbrella...
Read more >
An icon named “support”?! - Font Awesome
An icon named “support”?! ... We don't have that in our collection of 7,864 icons.
Read more >
Browser Support | Font Awesome Docs
Font Awesome supports and works out-of-the-box in the following web browsers ...
Read more >
Font Awesome
Always awesome. ... Font Awesome is the Internet's icon library and toolkit, used by millions of ... We have more icons, services, and...
Read more >
Browser Support | Font Awesome Docs
Font Awesome supports and works out-of-the-box in the following web browsers. If ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found