package.json.lerna_backup can get left behind after builds

We recently ran into an issue where a Lerna build left package.json.lerna_backup behind and it didn’t clean up after itself.

Expected Behavior

All builds should clean up build artifacts after they finish, successful or otherwise.

Current Behavior

package.json.lerna_backup can remain in the filesystem after a build completes.

Possible Solution

Steps to Reproduce (for bugs)

1. Run Lerna, apparently.
2. We don’t have clear repro steps; there wasn’t a build failure when this occurred.

@gigabo is familiar with our setup so I’m going to refrain from pasting configs unless requested.

[vyorkin]

I’m really suffering from the same problem. Almost every when time I got some postinstall error from one of subpackages (or any error at all) during install, my package.json is messed up and its content is replaced with lerna build artifacts. Every time this happens I need to remember to remove the current package.json and rename package.json.lerna_backup to package.json. Otherwhise (if I forget about this and do the npm i again after fixing the error) it will do weird things. I guess its possible to reproduce this by just pressing ctrl+c during install, not sure about this though. I believe this is incorrect behaviour and lerna should clean after itself in case of failure. What do you think?

[lock[bot]]

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.