Publishing errors with "Cannot find module '@octokit/request-error'"

Expected Behavior

No error, packages are versioned and published to npm.

Current Behavior

I can’t publish anymore. I published last on Tuesday Jun 11 and in the meantime we unlocked and let a bunch of minor and patch updates come through. Now all lerna publish commands error:

Cannot find module '@octokit/request-error'

Not great, but especially weird given the type of release I’m really trying to make right now. We have a type of pre-release we make that we call a “quick pre-release.” The objective is to create a timestamped pre-release that goes to npm, skipping all git-related stuff. The command we’ve been using is:

lerna publish prerelease --no-git-tag-version --no-push --npm-tag=quick --preid=$(date '+%Y%m%d%H%M%S')-quick --force-publish --yes --allow-branch quick/*

After getting the error, I also attempted this frantic everything-and-the-kitchen-sink variation after reviewing the documentation and noticing some new features since I wrote the original.

npx lerna publish prerelease --no-git-tag-version --no-push --dist-tag=quick --preid=$(date '+%Y%m%d%H%M%S')-quick --force-publish --yes --allow-branch quick/* --no-verify-registry --ignore-scripts --ignore-prepublish --no-git-reset --no-commit-hooks --no-changelog

Possible Solution

If I go into @lerna/github-client and comment out all the octokit-rest lines, I am able to get past the error and make my quick pre-release. See screenshot.

Obviously, I kinda need to be able to do normal releases that do involve git & GitHub, but it seems a little weird this code is getting hit when I’m making such an effort to skip all git-related actions.

Steps to Reproduce (for bugs)

I don’t know how to walk through a reproduction if this error isn’t happening widely to most users. I just have kinda a normal Lerna monorepo setup here. And I’m just trying to publish. Did a full clean install of all node modules from scratch (wiped everything out, including package locks and installed everything from a clean slate).

lerna.json

{
  "command": {
    "bootstrap": {
      "ci": false,
      "hoist": false
    },
    "exec": {
      "stream": true
    },
    "list": {
      "all": true,
      "long": true
    },
    "publish": {
      "allowBranch": "master",
      "commitHooks": true,
      "conventionalCommits": true,
      "independent": true,
      "message": "chore: publish dls"
    },
    "run": {
      "stream": true
    },
    "version": {
      "allowBranch": "master",
      "commitHooks": true,
      "conventionalCommits": true,
      "independent": true,
      "message": "chore: publish dls"
    }
  },
  "ignoreChanges": [
    "**/*.md",
    "**/.gitignore",
    "**/.gitkeep",
    "**/__fixtures__/**",
    "**/__tests__/**",
    "**/fixtures/**",
    "**/package-lock.json",
    "**/sketch/**",
    "**/test/**",
    "**/tests/**",
    "demos/angular/**",
    "demos/bundle/**",
    "packages/dls-falcor/demo/**",
    "tools/dls-icon-loader/demo/**",
    "tools/dls-tokenizer/demo/**"
  ],
  "lerna": "3.11.1",
  "packages": [
    "components/*",
    "components/employer/*",
    "components/falcor/*",
    "components/member/*",
    "demos/*",
    "packages/*",
    "primitives/*",
    "tokens/*",
    "tokens/employer/*",
    "tokens/falcor/*",
    "tokens/member/*",
    "tools/*"
  ],
  "version": "independent"
}

lerna-debug.log

None is generated by this error.

Context

Your Environment

Executable	Version
lerna --version	3.15.0
npm --version	6.9.0
node --version	10.15.0

OS	Version
macOS Mojave	10.14.4

These are the seemingly relevant dependency versions involved.

> npm ls lerna
dls@ /Users/rachael.moore/Projects/dls
└── lerna@3.15.0

> npm ls | grep @lerna
│ ├─┬ @lerna/add@3.15.0
│ │ ├── @lerna/bootstrap@3.15.0 deduped
│ │ ├─┬ @lerna/command@3.15.0
│ │ │ ├── @lerna/child-process@3.14.2 deduped
│ │ │ ├── @lerna/package-graph@3.14.0 deduped
│ │ │ ├─┬ @lerna/project@3.15.0
│ │ │ │ ├── @lerna/package@3.14.2 deduped
│ │ │ │ ├── @lerna/validation-error@3.13.0 deduped
│ │ │ ├── @lerna/validation-error@3.13.0 deduped
│ │ │ ├─┬ @lerna/write-log-file@3.13.0
│ │ ├─┬ @lerna/filter-options@3.14.2
│ │ │ ├── @lerna/collect-updates@3.14.2 deduped
│ │ │ ├─┬ @lerna/filter-packages@3.13.0
│ │ │ │ ├── @lerna/validation-error@3.13.0 deduped
│ │ ├─┬ @lerna/npm-conf@3.13.0
│ │ ├─┬ @lerna/validation-error@3.13.0
│ ├─┬ @lerna/bootstrap@3.15.0
│ │ ├─┬ @lerna/batch-packages@3.14.0
│ │ │ ├── @lerna/package-graph@3.14.0 deduped
│ │ ├── @lerna/command@3.15.0 deduped
│ │ ├── @lerna/filter-options@3.14.2 deduped
│ │ ├─┬ @lerna/has-npm-version@3.14.2
│ │ │ ├── @lerna/child-process@3.14.2 deduped
│ │ ├─┬ @lerna/npm-install@3.14.2
│ │ │ ├── @lerna/child-process@3.14.2 deduped
│ │ │ ├─┬ @lerna/get-npm-exec-opts@3.13.0
│ │ ├─┬ @lerna/package-graph@3.14.0
│ │ │ ├── @lerna/prerelease-id-from-version@3.14.0 deduped
│ │ │ ├── @lerna/validation-error@3.13.0 deduped
│ │ ├─┬ @lerna/pulse-till-done@3.13.0
│ │ ├─┬ @lerna/rimraf-dir@3.14.2
│ │ │ ├── @lerna/child-process@3.14.2 deduped
│ │ ├─┬ @lerna/run-lifecycle@3.14.0
│ │ │ ├── @lerna/npm-conf@3.13.0 deduped
│ │ ├─┬ @lerna/run-parallel-batches@3.13.0
│ │ ├─┬ @lerna/symlink-binary@3.14.2
│ │ │ ├─┬ @lerna/create-symlink@3.14.0
│ │ │ ├─┬ @lerna/package@3.14.2
│ │ ├─┬ @lerna/symlink-dependencies@3.14.2
│ │ │ ├── @lerna/create-symlink@3.14.0 deduped
│ │ │ ├─┬ @lerna/resolve-symlink@3.13.0
│ │ │ ├── @lerna/symlink-binary@3.14.2 deduped
│ │ ├── @lerna/validation-error@3.13.0 deduped
│ ├─┬ @lerna/changed@3.15.0
│ │ ├─┬ @lerna/collect-updates@3.14.2
│ │ │ ├── @lerna/child-process@3.14.2 deduped
│ │ │ ├── @lerna/describe-ref@3.14.2 deduped
│ │ ├── @lerna/command@3.15.0 deduped
│ │ ├─┬ @lerna/listable@3.14.0
│ │ │ ├─┬ @lerna/query-graph@3.14.0
│ │ │ │ ├── @lerna/package-graph@3.14.0 deduped
│ │ ├─┬ @lerna/output@3.13.0
│ │ └── @lerna/version@3.15.0 deduped
│ ├─┬ @lerna/clean@3.15.0
│ │ ├── @lerna/command@3.15.0 deduped
│ │ ├── @lerna/filter-options@3.14.2 deduped
│ │ ├─┬ @lerna/prompt@3.13.0
│ │ ├── @lerna/pulse-till-done@3.13.0 deduped
│ │ ├── @lerna/rimraf-dir@3.14.2 deduped
│ ├─┬ @lerna/cli@3.13.0
│ │ ├── @lerna/global-options@3.13.0
│ ├─┬ @lerna/create@3.15.0
│ │ ├─┬ @lerna/child-process@3.14.2
│ │ ├── @lerna/command@3.15.0 deduped
│ │ ├── @lerna/npm-conf@3.13.0 deduped
│ │ ├── @lerna/validation-error@3.13.0 deduped
│ ├─┬ @lerna/diff@3.15.0
│ │ ├── @lerna/child-process@3.14.2 deduped
│ │ ├── @lerna/command@3.15.0 deduped
│ │ ├── @lerna/validation-error@3.13.0 deduped
│ ├─┬ @lerna/exec@3.15.0
│ │ ├── @lerna/child-process@3.14.2 deduped
│ │ ├── @lerna/command@3.15.0 deduped
│ │ ├── @lerna/filter-options@3.14.2 deduped
│ │ ├─┬ @lerna/run-topologically@3.14.0
│ │ │ ├── @lerna/query-graph@3.14.0 deduped
│ │ ├── @lerna/validation-error@3.13.0 deduped
│ ├─┬ @lerna/import@3.15.0
│ │ ├── @lerna/child-process@3.14.2 deduped
│ │ ├── @lerna/command@3.15.0 deduped
│ │ ├── @lerna/prompt@3.13.0 deduped
│ │ ├── @lerna/pulse-till-done@3.13.0 deduped
│ │ ├── @lerna/validation-error@3.13.0 deduped
│ ├─┬ @lerna/init@3.15.0
│ │ ├── @lerna/child-process@3.14.2 deduped
│ │ ├── @lerna/command@3.15.0 deduped
│ ├─┬ @lerna/link@3.15.0
│ │ ├── @lerna/command@3.15.0 deduped
│ │ ├── @lerna/package-graph@3.14.0 deduped
│ │ ├── @lerna/symlink-dependencies@3.14.2 deduped
│ ├─┬ @lerna/list@3.15.0
│ │ ├── @lerna/command@3.15.0 deduped
│ │ ├── @lerna/filter-options@3.14.2 deduped
│ │ ├── @lerna/listable@3.14.0 deduped
│ │ └── @lerna/output@3.13.0 deduped
│ ├─┬ @lerna/publish@3.15.0
│ │ ├─┬ @lerna/check-working-tree@3.14.2
│ │ │ ├─┬ @lerna/collect-uncommitted@3.14.2
│ │ │ │ ├── @lerna/child-process@3.14.2 deduped
│ │ │ ├── @lerna/describe-ref@3.14.2 deduped
│ │ │ └── @lerna/validation-error@3.13.0 deduped
│ │ ├── @lerna/child-process@3.14.2 deduped
│ │ ├── @lerna/collect-updates@3.14.2 deduped
│ │ ├── @lerna/command@3.15.0 deduped
│ │ ├─┬ @lerna/describe-ref@3.14.2
│ │ │ ├── @lerna/child-process@3.14.2 deduped
│ │ ├─┬ @lerna/log-packed@3.13.0
│ │ ├── @lerna/npm-conf@3.13.0 deduped
│ │ ├─┬ @lerna/npm-dist-tag@3.15.0
│ │ │ ├─┬ @lerna/otplease@3.14.0
│ │ │ │ ├── @lerna/prompt@3.13.0 deduped
│ │ ├─┬ @lerna/npm-publish@3.15.0
│ │ │ ├── @lerna/otplease@3.14.0 deduped
│ │ │ ├── @lerna/run-lifecycle@3.14.0 deduped
│ │ ├── @lerna/output@3.13.0 deduped
│ │ ├─┬ @lerna/pack-directory@3.14.2
│ │ │ ├─┬ @lerna/get-packed@3.13.0
│ │ │ ├── @lerna/package@3.14.2 deduped
│ │ │ ├── @lerna/run-lifecycle@3.14.0 deduped
│ │ ├─┬ @lerna/prerelease-id-from-version@3.14.0
│ │ ├── @lerna/prompt@3.13.0 deduped
│ │ ├── @lerna/pulse-till-done@3.13.0 deduped
│ │ ├── @lerna/run-lifecycle@3.14.0 deduped
│ │ ├── @lerna/run-topologically@3.14.0 deduped
│ │ ├── @lerna/validation-error@3.13.0 deduped
│ │ ├── @lerna/version@3.15.0 deduped
│ ├─┬ @lerna/run@3.15.0
│ │ ├── @lerna/command@3.15.0 deduped
│ │ ├── @lerna/filter-options@3.14.2 deduped
│ │ ├─┬ @lerna/npm-run-script@3.14.2
│ │ │ ├── @lerna/child-process@3.14.2 deduped
│ │ │ ├── @lerna/get-npm-exec-opts@3.13.0 deduped
│ │ ├── @lerna/output@3.13.0 deduped
│ │ ├── @lerna/run-topologically@3.14.0 deduped
│ │ ├── @lerna/timer@3.13.0
│ │ ├── @lerna/validation-error@3.13.0 deduped
│ ├─┬ @lerna/version@3.15.0
│ │ ├── @lerna/check-working-tree@3.14.2 deduped
│ │ ├── @lerna/child-process@3.14.2 deduped
│ │ ├── @lerna/collect-updates@3.14.2 deduped
│ │ ├── @lerna/command@3.15.0 deduped
│ │ ├─┬ @lerna/conventional-commits@3.14.0
│ │ │ ├── @lerna/validation-error@3.13.0 deduped
│ │ ├─┬ @lerna/github-client@3.14.2
│ │ │ ├── @lerna/child-process@3.14.2 deduped
│ │ ├─┬ @lerna/gitlab-client@3.15.0
│ │ ├── @lerna/output@3.13.0 deduped
│ │ ├── @lerna/prerelease-id-from-version@3.14.0 deduped
│ │ ├── @lerna/prompt@3.13.0 deduped
│ │ ├── @lerna/run-lifecycle@3.14.0 deduped
│ │ ├── @lerna/run-topologically@3.14.0 deduped
│ │ ├── @lerna/validation-error@3.13.0 deduped

> npm ls | grep @octo
│ │ │ ├── @octokit/plugin-enterprise-rest@2.2.2
│ │ │ ├─┬ @octokit/rest@16.28.1
│ │ │ │ ├─┬ @octokit/request@4.1.0
│ │ │ │ │ ├─┬ @octokit/endpoint@5.1.5
│ │ │ │ │ ├── @octokit/request-error@1.0.3 deduped
│ │ │ │ ├─┬ @octokit/request-error@1.0.3

[evocateur]

I find npm ls -lp <pkgname> to be more useful when attempting to debug these sorts of things, as it will output the literal path(s) that this package has been unpacked to under node_modules, instead of a (potentially) misleading symbolic tree.

I do agree that we could be slightly more respectful of folks who don’t use the --create-release flag by delaying the require of the module entirely, which would workaround your particular error case. (As far as I can tell, this isn’t actually a problem with Lerna directly, aside from requiring the module that we expect package managers to lay out on disk properly).

[rahuljain-tt]

I am also facing same issue @morewry can you help me how you fix this? I tried below steps

• lerna clean (to delete all node_modules in child packages)
• deleted all package.lock file manually
• lerna version --conventional-commits --create-release github

Tag were create on github but release is not there.