question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`--sync-workspace-lock` not working with `lerna version`

See original GitHub issue

Describe the bug

I’m not sure if this is design behavior, --sync-workspace-lock maybe only is only meaningful for lerna release, but I don’t have a new version to release yet so I can’t try with lerna release. 🤣

Expectation

Run lerna version --sync-workspace-lock should changes pnpm-lock.yaml.

Reproduction

Clone https://github.com/johnsoncodehk/volar and run and run $ pnpm i && npm run version:test.

Lerna config and logs

lerna.json

{
	"packages": [
		"extensions/*",
		"packages/*"
	],
	"version": "0.37.3"
}

Environment Info

| Executable        | Version |
| ----------------- | ------- |
| `lerna --version` | 4.0.0 |
| `npm --version`   | 8.5.5 |
| `yarn --version`. | 1.22.4 |
| `pnpm --version`  | 7.0.0 |
| `node --version`  | v16.15.0 |

Used Package Manager

pnpm

Validations

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
johnsoncodehkcommented, Jun 9, 2022

I don’t know it, but I think I will not use workspace: after take a look, because it’s only works for pnpm publish, but the pakcages in https://github.com/johnsoncodehk/volar/tree/master/extensions are is use vsce not pnpm to release. If I only use workspace: for https://github.com/johnsoncodehk/volar/tree/master/packages packages it brings some inconsistencies and confusion to the project. But thanks for let me know it!

Thanks for the kind words, glad to know that my approach was correct and that I wasn’t the only one with that in mind 😃

Please trust your decision more in the repo. 😃

1reaction
johnsoncodehkcommented, Jun 9, 2022

I always prefer 1. if I can, because more explicit behavior means less code, less documentation, and more predictability to me. But I believe peoples have different expectations.

Let me know what you think is best, you are my biggest user after all (the lib with the most stars), happy to have you on board 😉

I’m think large projects just can’t move so fast to migrate to lerna-lite in a short period of time, but I would definitely recommend lerna-lite to others. 😉

Read more comments on GitHub >

github_iconTop Results From Across the Web

lerna-lite/README.md at main - GitHub
When run, this command does the following: Identifies packages that have been updated since the previous tagged release. Prompts for a new version....
Read more >
@lerna-lite/publish - npm
Start using @lerna-lite/publish in your project by running `npm i ... packages where the latest version is not present in the registry.
Read more >
Troubleshooting | Lerna
Troubleshooting. This document contains solutions for certain issues our users encountered in the past while using Lerna.
Read more >
Lerna always lists all packages ready to publish when running ...
the step which I run lerna updated in my github actions workflow always tells/lists me all the package are available to publish which...
Read more >
Starting with Monorepos using Lerna - Joel H. Gomez Paredes
To solve some problems we can use a tool called Lerna. ... Fixed/Locked (default): All packages have the same version specified in lerna.json....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found