Bug: adding zero notes causes crash

If you run apy add but change your mind and don’t add anything (e.g. straight away pressing :wq in Vim or Ctrl-X in Nano), it crashes:

[ckp95@ckp95-laptop anki]$ apy add
reverting to stock json
Dupe detected, note was not added!
Question:

Traceback (most recent call last):
  File "/home/ckp95/.local/bin/apy", line 8, in <module>
    sys.exit(main())
  File "/home/ckp95/.local/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/ckp95/.local/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/ckp95/.local/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/ckp95/.local/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/ckp95/.local/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/ckp95/.local/lib/python3.8/site-packages/apy/cli.py", line 75, in add
    click.echo(f'Added note to deck: {decks[0]}')
IndexError: list index out of range

[lervag]

Thanks! I added a similar check for the n_notes attribute. In principle, I think there might still be a slight bug here, since the empty.md note is still parsed and we try to add it. It is detected as a dupe and so no notes are actually added.

In any case, I think the point here is not to become perfect. Good is good enough. When I make mistakes, I have found I can still use apy to fix them quite easily with the apy review function.

I really appreciate your effort, it is very nice to get some help in fixing issues and improving this utility. apy is already at 95% fully functional for me, but it might have some rough edges especially with regard to other users workflows and similar. As such, it is very nice to get help in fixing these.

[lervag]

Thanks! I’ve copied your cli tests! I was not aware of the click.testing module and I very much like the use of the temporary directories for testing as you’ve done here. Again, thanks!

Also, I can now reproduce the error and I’ll look into a way to fix it!