Plugin method install() runs before setOptions()

This breaks plugins like less-plugin-autoprefix in Less v3.x.

Test Plugin

less-plugin-test/index.js in global node_modules:

module.exports = {
	install: function (less, pluginManager) {
		console.group('running install()')
		console.log('this.options:', this.options)
		console.groupEnd()
	},
	setOptions: function(options) {
		console.group('running setOptions()')
		this.options = options
		console.log('this.options:', this.options)
		console.groupEnd()
	},
}

Less 2.x

npm i -g less@2 && lessc --test="test" empty.less

Result:

running setOptions()
  this.options: test
running install()
  this.options: test

Less 3.x (including 3.5.0-beta)

npm i -g less@3.5.0-beta && lessc --test="test" empty.less

Result:

running install()
  this.options: undefined
running setOptions()
  this.options: test

[matthew-dean]

Okay, I merged, so I’ll close this.

[calvinjuarez]

Yup, this fixes less-plugin-autoprefix. I’m gonna quick look into maybe only doing the double-run for plugins with minimum version < 3, but I don’t think this should wait for that, since it’s possibly getting in the way of people’s workflows.