urlQuotes throwing warning for LESS variable

Which version of lesshint are you using? 3.1.0

How are you running lesshint? CLI, Node.js API, Grunt/Gulp plugin? Gulp

What’s your .lesshintrc configuration?

{
    "fileExtensions": [".less"],
    "spaceAfterPropertyColon": {
        "enabled": true,
        "style": "one_space" // Comments are allowed
    },
    "propertyOrdering": {
        "enabled": false
    },
    "maxCharPerLine": {
        "enabled": false
    }
}

If you’re reporting a bug, please show us some code that’s failing.

@brand-logo: '/assets/images/logo.svg';

.head-logo {
	background: url(@brand-logo);
}

What did you expect to happen? No warning. The variable evaluates to a properly quoted url.

What’s the actual result? I get this warning: urlQuotes: URLs should be enclosed in quotes

Technically, I could write the background declaration as background: url('@{brand-logo}'); to prevent the warning, but it feels weird to add unnecessary interpolation just to make the linter happy. Thoughts?

[jwilsson]

Thanks for the extra examples!

I agree that a URL without a slash seems unlikely, and we can never be sure of what the variable actually contains. I still think just ignoring variables in url() is fine (FWIW I checked other linters and they do it too).

A PR would be highly appreciated! Let us know if you need anything.

[jwilsson]

Closed in #366.