Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

cancelCommandsOnReconnectFailure should have appropriate warnings.

See original GitHub issue

Feature Request

Is your feature request related to a problem? Please describe

These problems may be caused by cancelCommandsOnReconnectFailure being set to true. https://github.com/lettuce-io/lettuce-core/issues/1753 https://github.com/lettuce-io/lettuce-core/issues/1645 https://github.com/lettuce-io/lettuce-core/issues/915

Describe the solution you’d like

When cancelCommandsOnReconnectFailure is true, reset() may be called if reconnect fails. The reset() command can cause serious issue, as pointed out in these issues.

https://github.com/lettuce-io/lettuce-core/issues/907#issuecomment-434392684 https://github.com/lettuce-io/lettuce-core/blob/ee3e70f613074531aef9874a01bbbeb72dbd2cbb/src/main/java/io/lettuce/core/RedisChannelWriter.java#L73

However, the cancelCommandsOnReconnectFailure option does not any warnings about the possibility of causing a protocol offset now. https://github.com/lettuce-io/lettuce-core/blob/cda3be6b9477da790365ad098c6e39c8687f5002/src/main/java/io/lettuce/core/ClientOptions.java#L203 https://github.com/lettuce-io/lettuce-core/wiki/Client-Options

Therefore, at the least, these possibility should be fully explained.