Invalid Reverse Iterator Seek Test

It seems the test for iterator#seek() on reverse iterator is invalid. This test uses make which batches three items with keys one, two, three, then creates an iterator with { reverse: true, limit: 1 }, then attempts to seek to key three! expecting to find it and for the key to be three.

Possibly invalid assumptions:

1. Items are stored in the order they are received: { reverse: true, limit: 1 }
2. Key seeking is done by subset matching: three! != three but does start with three

Possible changes:

1. Remove { limit: 1 } to seek all items in reverse and tolerate the subset match
2. Correct the seek('three!') call to be seek('three')

If both changes are made then this test passes. Am I missing some reason why this is a valid test?

[vweevers]

The limit applies to the total number of items retrieved, not to what’s on disk. It does a seek first, then from it where landed, retrieves items until the limit is reached.

[GioCirque]

Ahhh, I see now. Thank you for that explanation. This might be a good explanation to add to the iterator documentation? I’ll close this issue. Sorry for the trouble.