Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove _isBuffer?

See original GitHub issue

Implementations no longer have a need to override _isBuffer in order to use typed arrays as buffers. Because with modern browserify, Buffer is a subclass of Uint8Array and conversions between the two are cheap. I.e. we can use Buffer (and Buffer.isBuffer) everywhere.

@ralphtheninja @juliangruber

Issue Analytics

State:
Created 6 years ago
Reactions:2
Comments:12 (12 by maintainers)

Top GitHub Comments

1reaction

ralphtheninjacommented, Dec 23, 2017

Both true. I want to settle somewhere in between, in order to continue with memdown, my fork of localstorage-down and eventually level-js.

Since you’re actively developing on those *downs, lets have them drive the progress of abstract-leveldown. I’d like to remove approximateSize and then I’m happy with a new major.

0reactions

vweeverscommented, Dec 23, 2017

→ #170

Top Results From Across the Web

Node.js Buffer.isBuffer() Method - W3Schools

isBuffer () method returns true if the specified object is a Buffer, otherwise false. Syntax. Buffer.isBuffer(obj);. Parameter Values. Parameter, Description.

Buffer | Node.js v19.3.0 Documentation

A TypeError will be thrown if string is not a string or another type appropriate for Buffer.from() variants. Static method: Buffer.isBuffer(obj) #. Added...

Remove node-specific reference to Buffer - isaacs/core-util-is

This references to Buffer makes this library incompatible in the browser because Buffer is part of the node API and is not available...

Lodash _.isBuffer() Method - GeeksforGeeks

isBuffer () Method Checks if the given value is Buffer or not. ... console.log( "The Value is Buffer : " ... Lodash |...

is-buffer - npm

This module lets you check if an object is a Buffer without using Buffer.isBuffer (which includes the whole buffer module in browserify). It's ......