question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Singular way to signal iteration end

See original GitHub issue

From https://github.com/Level/concat-iterator/issues/1#issuecomment-399747452:

So atm, there’s two ways in the ecosystem to detect the end of iteration:

  1. arguments.length === 0
  2. key === undefined && value === undefined

We gotta pick one and stick with it.

And

this should be specified in abstract-leveldown and the tests should enforce this.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
vweeverscommented, Jun 24, 2018

In other words, no change is required in abstract-leveldown, but since we aren’t supporting undefined anyway, we should make that official.

1reaction
vweeverscommented, Jun 24, 2018

I prefer the key-value check, it covers more ground. Because if no arguments are passed, then key === undefined && value === undefined is also true.

@ralphtheninja WDYT?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Cadzow's basic algorithm, alternating projections and singular ...
This paper will describe two methods commonly used to remove noise from a signal; the so-called singular spectrum analysis, and Cadzow's basic algorithm....
Read more >
Singular value decomposition - Wikipedia
In linear algebra, the singular value decomposition (SVD) is a factorization of a real or complex matrix. It generalizes the eigendecomposition of a...
Read more >
Singular Spectrum Decomposition and Iteration Sparsity ...
Abstract: The singular spectrum decomposition (SSD) can decompose the original signal into several singular spectrum components (SSC).
Read more >
Application of Improved Singular Spectrum Decomposition ...
[12] proposed a new adaptive signal processing method: singular spectrum decomposition (SSD), ... (4) Setting of iteration stop condition.
Read more >
Iterative Methods for Singular Linear Equations and Least ...
For a singular matrix of arbitrary shape, we observe that null vectors can be obtained by solving least-squares problems involving the transpose of...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found