Conflicting line length rule with scalafmt

So far this plugin works really nice 🙂 . I only encountered the following issue. I have an import statement as follows:

import sttp.client.{
  DeserializationError,
  HttpError,
  NothingT,
  Response,
  ResponseAs,
  ResponseError,
  SttpBackend,
  basicRequest
}

scalafix-organize-imports tries to rewrite it to

import sttp.client.{DeserializationError, HttpError, NothingT, Response, ResponseAs, ResponseError, SttpBackend, basicRequest}

while scalafmt insists on the original formatting. My .scalafmt.conf:

version = "2.4.1"

align = more
maxColumn = 100
rewrite {
  rules = [
    SortModifiers,
    RedundantBraces,
    PreferCurlyFors
  ]

  redundantBraces.stringInterpolation = true
}

and .scalafix.conf:

rules = [
  NoAutoTupling,
  DisableSyntax,
  LeakingImplicitClassVal,
  NoValInForComprehension,
  ProcedureSyntax,
  OrganizeImports
]

OrganizeImports {
  groupedImports = Merge
}

[arjun-1]

Excellent! Indeed the issue is resolved with 0.3.0+5-98c374f1-SNAPSHOT 😃

[liancheng]

@arjun-1, thank you so much for the minimal reproduction! I figured out why it didn’t work for you. It’s because you are using Scala 2.13 while OrganizeImports is built using Scala 2.12.

OrganizeImports calls importer.syntax to pretty-print an import expression. Internally, the syntax method accepts an implicit scala.meta.Dialect parameter. While pretty-printing, the syntax method checks two things:

1. Whether this AST node originates directly from the parser.
2. Whether the Scala dialect of the original source being parsed comforms to the implicit dialect.

When both conditions are true, it simply returns the original source text being parsed. Otherwise, it pretty-prints the AST node using the implicit dialect.

OrganizeImports is built using Scala 2.12, so at runtime, this implicit dialect is by default Scala 2.12. Therefore, condition 2 doesn’t hold.

Instead, we can simply replace the importer.syntax with importer.toString. The latter doesn’t check condition 2. So it always returns the original source text if an import originates from the parser. In other cases, it always uses Scala 2.11 dialect, which is also good enough for pretty-printing import statements.