Add the ability to clear all pools in Pools

I think it would be useful to add the ability to clear all pools that are stored internally in Pools via the static variable typePools. The implementation seems to be rather straightforward: Simply iterate over all the pools and call their clear method. Something like this:

public class Pools {
    // ...
    public static void clear() {
        for (ObjectMap.Entry<Class, Pool> entry : typePools)  {
            entry.value.clear();
        }
    }
}

[cypherdare]

I’m going to close this, as a valid use case that doesn’t abuse the handling of Disposables was never demonstrated. Disposables aren’t practical to place into ReflectionPools, as any of the libGDX classes implementing Disposable are unlikely to have a useful empty constructor and also be the sort of thing you need many of.

Suppose you want to pool Pixmaps or FrameBuffers. These don’t have useful empty constructors. You would need to make your own Pool that calls a specific constructor with specific parameters in newObject(). And then you can freeAll() your own pool when the game is disposed.

If a reflection-pooled class references Disposable objects that it does not own, it should null out the references in reset().

[cypherdare]

@asherbar, I think @xGnoSiSx was maybe assuming this clearing would be automatically done, which I don’t think you were suggesting.

Seems like since this is apparently the only use case, you’d actually want a clearDisposables method that clears only the objects that implement Disposable. The sample code you gave would result in leaking all Disposables. It should look something like this:

public static void clearDisposables() {
    for (ObjectMap.Entry<Class, Pool> entry : typePools)  {
        if (entry.key.isAssignableFrom(Disposable.class){
            Pool pool = entry.value;
            while (pool.getFree() > 0) ((Disposable)pool.obtain()).dispose();
        }
    }
}