Horizontal ScrollPanes done borked

Line 438 in recent Snapshot of ScrollPane:

hScrollBounds.set(x, y, widgetArea.width, scrollbarWidth);

Should be scrollbarHeight, tested it with a duplicated class and fixed the problem. Right now the bounds height is 0 so no visual bar / not clickable.

PS It’d be neat if LibGDX (scene2D) classes didn’t have so many package-protected members to make simple modifications through anonymous inner classes easier 😕

[obigu]

@NathanSweet Suggestion is to make fields and methods protected, not public. This way, subclasses can access or override. It is asked regularly.

I guess @MrStahlfelge you meant private instead of public hence the misunderstanding.

In my personal experience I’ve found some limitations when trying to create my own widgets by extending Scene2D classes, not that much because of private modifiers but because of default/package modifiers. Within the com.badlogic.gdx.scenes.scene2d.ui there’s quite some room for extensibility but it gets more limited outside it. To overcome this limitations I’ve had to create a com.badlogic.gdx.scenes.scene2d.ui package in some of my apps just to be able to extend some widgets without copying the whole thing (ScrollPane is an example).

[NathanSweet]

The existance of the issue and the change just proves the point that there are a lot of package-private or private fields and methods that should be protected or public.

The issue is that a getter was missing, not that everything should be public.

I don’t see anything beingprotected as public. I don’t think that changing protected stuff is API breakage.

Protected members appear in the public API, users are free to use them at will and without expecting breakage. FWIW see Effective Java by Joshua Bloch or his talks on API design. Not that it’s a bible, just that I’m not inventing things.

This scenario isn’t specific to scene2d, every library faces this.