ParticleEffect modification broke Particle Effect on GWT module #5280

Issue “Life attribute on Particle Emitter is not applied to particles individually” with ID #5280 broke Particle loader for the HTML/gwt module

Issue details

A new parameter (independent) has been added to the ParticleEffect configuration file “.p”. In order to ensure backward compatibility the lifeValue.loader in class ParticleEmitter has been updated with a mark(100) followed by a reset (see below). Problem is,

• On Desktop, Android, calling that works.
• On GWT this triggers an Exception as there is no implementation for the BuffereredReader.mark() method. This calls by default the method on Reader.java which by default raises an exception.

In class ParticleEmitter:

public void load (BufferedReader reader) throws IOException {
			super.load(reader);
			// For backwards compatibility, independent property may not be defined
			reader.mark(100);
			String line = reader.readLine();
			if (line == null) throw new IOException("Missing value: " + "independent");
			if (line.contains("independent"))
				independent = Boolean.parseBoolean(readString(line));
			else
				reader.reset();
		}

Reproduction steps/code

Run the Out of the box Tests on GWT, select the following test com.badlogic.gdx.tests.ParticleEmitterTest

You will get the Exception outlined in the stacktrace section below.

The issue does not happen with the android or Desktop module (which is probably why this went undetected).

Version of LibGDX and/or relevant dependencies

LibGDX Version: 1.9.9-SNAPSHOT

Stacktrace

Uncaught Error: com.badlogic.gdx.utils.GdxRuntimeException: Error loading effect: data/test.p
    at rLd.JKd [as dyb] (com.badlogic.gdx.tests.gwt.GdxTestsGwt-0.js:159)
    at rLd.SKd [as lyb] (com.badlogic.gdx.tests.gwt.GdxTestsGwt-0.js:159)
    at rLd.EKd (com.badlogic.gdx.tests.gwt.GdxTestsGwt-0.js:159)
    at rLd.eLd (com.badlogic.gdx.tests.gwt.GdxTestsGwt-0.js:159)
    at rLd.lLd (com.badlogic.gdx.tests.gwt.GdxTestsGwt-0.js:159)
    at new rLd (com.badlogic.gdx.tests.gwt.GdxTestsGwt-0.js:159)
    at ZX.jY [as zt] (com.badlogic.gdx.tests.gwt.GdxTestsGwt-0.js:120)
...
com.badlogic.gdx.tests.gwt.GdxTestsGwt-0.js:159 Uncaught Error: java.lang.RuntimeException: com.google.gwt.core.client.JavaScriptException: (TypeError) : Cannot read property 'pwb' of undefined
    at mLd.JKd [as dyb] (com.badlogic.gdx.tests.gwt.GdxTestsGwt-0.js:159)
    at mLd.SKd [as lyb] (com.badlogic.gdx.tests.gwt.GdxTestsGwt-0.js:159)
    at mLd.FKd (com.badlogic.gdx.tests.gwt.GdxTestsGwt-0.js:159)
...

Please select the affected platforms

• Android
• iOS (robovm)
• iOS (MOE)
• HTML/GWT
• Windows
• Linux
• MacOS

[obigu]

Here you go https://github.com/libgdx/libgdx/pull/5637, now let’s hope it gets merged

[obigu]

AFAIK it will only break trying to load particle effects that use the old format. I believe it doesn’t make sense anymore to merge the “hacky” solution as backwards compatibility has already been broken for a while. https://github.com/libgdx/libgdx/pull/5374 is still open and should be merged to cleanly handle GWT non supported classes and update the particle effects test files to the latest format. EDIT: I remember now https://github.com/libgdx/libgdx/pull/5374 has a formatting issue. I was waiting for confirmation/feedback to fix it. Will do if there’s interest.