TmxLoader Changed it's behavior

Hi Guys.

I found a backward compatibality issue in the 1.9.10 regarding Tmxloader.

I have <tileset firstgid="2" source="untitled.tsx"/> In my tmx file and all cells that are active have a 2 value (otherwise they have 0 value).

So , my code worked great before 1.9.10 version, but now I found, that all cells in all layers are null.

So, after some debugging, I found that now

<tileset firstgid="2" source="untitled.tsx"/>

not working as expected.

In this code.

protected void loadTileSet (Element element, FileHandle tmxFile, ImageResolver imageResolver) {
		if (element.getName().equals("tileset")) {
			String imageSource = "";
			int imageWidth = 0;
			int imageHeight = 0;
			FileHandle image = null;

			String source = element.getAttribute("source", null);
			if (source != null) {
				FileHandle tsx = getRelativeFileHandle(tmxFile, source);
				try {
					element = xml.parse(tsx);
					Element imageElement = element.getChildByName("image");
					if (imageElement != null) {
						imageSource = imageElement.getAttribute("source");
						imageWidth = imageElement.getIntAttribute("width", 0);
						imageHeight = imageElement.getIntAttribute("height", 0);
						image = getRelativeFileHandle(tsx, imageSource);
					}
				} catch (SerializationException e) {
					throw new GdxRuntimeException("Error parsing external tileset.");
				}
			} else {
				Element imageElement = element.getChildByName("image");
				if (imageElement != null) {
					imageSource = imageElement.getAttribute("source");
					imageWidth = imageElement.getIntAttribute("width", 0);
					imageHeight = imageElement.getIntAttribute("height", 0);
					image = getRelativeFileHandle(tmxFile, imageSource);
				}
			}

			String name = element.get("name", null);
			int firstgid = element.getIntAttribute("firstgid", 1);
			int tilewidth = element.getIntAttribute("tilewidth", 0);
			int tileheight = element.getIntAttribute("tileheight", 0);
			int spacing = element.getIntAttribute("spacing", 0);
			int margin = element.getIntAttribute("margin", 0);

			Element offset = element.getChildByName("tileoffset");
			int offsetX = 0;
			int offsetY = 0;
			if (offset != null) {
				offsetX = offset.getIntAttribute("x", 0);
				offsetY = offset.getIntAttribute("y", 0);
			}

			TiledMapTileSet tileSet = new TiledMapTileSet();

			// TileSet
			tileSet.setName(name);
			final MapProperties tileSetProperties = tileSet.getProperties();
			Element properties = element.getChildByName("properties");
			if (properties != null) {
				loadProperties(tileSetProperties, properties);
			}
			tileSetProperties.put("firstgid", firstgid);

			// Tiles
			Array<Element> tileElements = element.getChildrenByName("tile");

			addStaticTiles(tmxFile, imageResolver, tileSet, element, tileElements, name, firstgid, tilewidth, tileheight, spacing,
				margin, source, offsetX, offsetY, imageSource, imageWidth, imageHeight, image);

			for (Element tileElement : tileElements) {
				int localtid = tileElement.getIntAttribute("id", 0);
				TiledMapTile tile = tileSet.getTile(firstgid + localtid);
				if (tile != null) {
					addTileProperties(tile, tileElement);
					addTileObjectGroup(tile, tileElement);
					addAnimatedTile(tileSet, tile, tileElement, firstgid);
				}
			}

			map.getTileSets().addTileSet(tileSet);
		}
	}

the element before this line try { element = xml.parse(tsx); has an anttribute firstgid which value is 2, but after that line the element doesn’t have the firstgid , so in the following line int firstgid = element.getIntAttribute("firstgid", 1); the firstgid variable gets the 1 value instead of 2.

So , i changed all 2’s in my tmx to the 1, and it worked as expected.

Could you please guys look into it before a stable release of the 1.9.10 version ?

Thanks a lot.

[TCreutzenberg]

The issue should be fixed with this pull request: https://github.com/libgdx/libgdx/pull/5710 It worked fine when I was testing it.

[bachtrong43]

@TCreutzenberg just created a new pull request.