Branch has TrackedBranch for non existent branch

LibGit2Sharp is reporting a tracked branch for a non-existent remote.

Output of git branch -a

  branch-no-remote
  master
* some-branch
  remotes/origin/master
  remotes/origin/some-branch

Here’s what libgit2sharp reports if I iterate through every branch in this repository and print out some properties:

  ---------------------------------------
  CanonicalName: refs/heads/branch-no-remote
  Tracked Branch: refs/remotes/origin/branch-no-remote
  IsTracking: True
  IsRemote: False
  IsCurrentRepositoryHead: False
  ---------------------------------------
  CanonicalName: refs/heads/master
  Tracked Branch: refs/remotes/origin/master
  IsTracking: True
  IsRemote: False
  IsCurrentRepositoryHead: False
  ---------------------------------------
  CanonicalName: refs/heads/some-branch
  Tracked Branch: refs/remotes/origin/some-branch
  IsTracking: True
  IsRemote: False
  IsCurrentRepositoryHead: True
  ---------------------------------------
  CanonicalName: refs/remotes/origin/master
  Tracked Branch: (null)
  IsTracking: False
  IsRemote: True
  IsCurrentRepositoryHead: False
  ---------------------------------------
  CanonicalName: refs/remotes/origin/some-branch
  Tracked Branch: (null)
  IsTracking: False
  IsRemote: True
  IsCurrentRepositoryHead: False

Notice that refs/heads/branch-no-remote is reporting a tracked branch of refs/remotes/origin/branch-no-remote which does not exist in this repository.

Where’s it getting it? From the .git\config I suppose.

[core]
    bare = false
    repositoryformatversion = 0
    filemode = false
    logallrefupdates = true
    symlinks = false
    ignorecase = true
[remote "origin"]
    url = https://github.com/Haacked/publish-test.git
    fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
    remote = origin
    merge = refs/heads/master
[branch "some-branch"]
    remote = origin
    merge = refs/heads/some-branch
[branch "branch-no-remote"]
    remote = origin
    merge = refs/heads/branch-no-remote

I suspect that libgit2sharp is using the branch remote info to populate the TrackedBranch property. But it probably shouldn’t, right?

[haacked]

@dahlbyk so what’s the cleanest way to determine if the TrackingBranch really is tracking something?

branches[branch.TrackingBranch.Name] != null

[felixfbecker]

I also got tripped up by this. What is the recommended way to check?

branch.TrackedBranch.Tip != null
// or maybe
branch.TrackedBranch.Reference is VoidReference

?

What do you think about adding an IsGone property to Branch? That would use the same wording that git branch -vv uses for gone branches:

  deduplicate                               9b9cb5ec42 [origin/deduplicate: gone] deduplicate

and devs would hopefully use that property before getting tripped up by TrackedBranch